Python: bug fixes from graphrag insights #10270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Based on insights from the graphrag team, several bug fixes related to data and model validators.
Description
For all cases of model_validator in before mode, there is no guarantee that the data passed is a dict,
especially when a model is used as a field in another model, then a string is passed to the before validator.
So in those cases we check before doing logic, otherwise just pass it on and let Pydantic handle the invalid data.
Some small logic fixes in the vector store model decorator:
Contribution Checklist