-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: experimental py3.13 support #10276
base: main
Are you sure you want to change the base?
Conversation
Python Test Coverage Report •Python Unit Test Overview
|
8b03585
to
6314b60
Compare
8786840
to
1a861b1
Compare
echo "Installing python 3.10, 3.11, 3.12" | ||
uv python install 3.10 3.11 3.12 | ||
echo "Installing python versions" | ||
uv python install 3.10 3.11 3.12 3.13 3.13t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my education: what is 3.13t? I couldn't find mentions of it online.
"transformers[torch] ~= 4.28", | ||
"sentence-transformers >= 2.2,< 4.0", | ||
"torch == 2.5.1" | ||
"transformers[torch] ~= 4.28; python_version < '3.13'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean people won't be able to use the hugging face and some other integrations on 3.13?
@@ -69,6 +76,8 @@ def __init__( | |||
|
|||
Note that this model will be downloaded from the Hugging Face model hub. | |||
""" | |||
if not ready: | |||
raise ImportError("torch is required to use HuggingFaceTextCompletion.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, adding to my previous comment: if we only offer a partial feature set on 3.13, what are the pros and cons of supporting 3.13 given our priorities?
Motivation and Context
Some small fixes in uv setup within actions
Added experimental unit tests runs for py3.13, 3.13t and the latter with and without GIL
Moved onnxxruntime-genai, torch, transformers and sentence-transformers to <py3.13
Description
Contribution Checklist