Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: experimental py3.13 support #10276

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

eavanvalkenburg
Copy link
Member

Motivation and Context

Some small fixes in uv setup within actions
Added experimental unit tests runs for py3.13, 3.13t and the latter with and without GIL
Moved onnxxruntime-genai, torch, transformers and sentence-transformers to <py3.13

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner January 23, 2025 15:26
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jan 23, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 23, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/ai/hugging_face
   hf_prompt_execution_settings.py26485%11–13, 31
semantic_kernel/connectors/ai/hugging_face/services
   hf_text_completion.py67790%33–35, 80, 112, 121, 136
   hf_text_embedding.py39977%34–36, 63, 92–96
semantic_kernel/connectors/ai/onnx/services
   onnx_gen_ai_completion_base.py612264%17–18, 40, 69–91
semantic_kernel/processes/dapr_runtime
   dapr_process_info.py32488%26, 31, 41, 48
   dapr_step_info.py31294%30, 39
semantic_kernel/processes/dapr_runtime/actors
   external_event_buffer_actor.py551278%52–55, 77–80, 103–106
   process_actor.py24311353%70–74, 79, 82, 88, 91, 95, 101, 104, 120–123, 128, 141, 159–163, 168, 178, 183, 192–200, 204–206, 214–222, 233, 249–310, 315, 326, 340–348, 351–358, 362–390, 421–434
   step_actor.py25415240%77–81, 86, 89, 93–94, 106–108, 152–155, 169–171, 176–252, 256–354, 358, 362–365, 369–385, 389–410, 414–432, 436–439, 443, 447–450
semantic_kernel/processes/kernel_process
   kernel_process_step_context.py18194%38
semantic_kernel/processes/local_runtime
   local_kernel_process_context.py32294%66–67
   local_process.py1345261%92, 102, 120–130, 163–190, 194–199, 203, 207–213, 217–227, 231–232
   local_step.py16610239%62, 72, 81–171, 175, 179, 183–184, 189–251, 255–258, 262–265, 269–278, 284–287, 291–293
semantic_kernel/utils/telemetry/model_diagnostics
   decorators.py1891194%60–63, 380–382, 426–429
TOTAL16995184589% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3021 5 💤 0 ❌ 0 🔥 1m 25s ⏱️

echo "Installing python 3.10, 3.11, 3.12"
uv python install 3.10 3.11 3.12
echo "Installing python versions"
uv python install 3.10 3.11 3.12 3.13 3.13t
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my education: what is 3.13t? I couldn't find mentions of it online.

"transformers[torch] ~= 4.28",
"sentence-transformers >= 2.2,< 4.0",
"torch == 2.5.1"
"transformers[torch] ~= 4.28; python_version < '3.13'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean people won't be able to use the hugging face and some other integrations on 3.13?

@@ -69,6 +76,8 @@ def __init__(

Note that this model will be downloaded from the Hugging Face model hub.
"""
if not ready:
raise ImportError("torch is required to use HuggingFaceTextCompletion.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, adding to my previous comment: if we only offer a partial feature set on 3.13, what are the pros and cons of supporting 3.13 given our priorities?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants