Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: prompt template config and kernel args support for agents #10298

Merged
merged 8 commits into from
Jan 28, 2025

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

To bring the SK Python framework closer to .Net parity, we need to support the ability to specify a prompt template config and kernel arguments for ChatCompletion Agents as well as for Assistant Agents.

Description

This PR adds support for:

Contribution Checklist

@moonbox3 moonbox3 added python Pull requests for the Python Semantic Kernel agents labels Jan 27, 2025
@moonbox3 moonbox3 self-assigned this Jan 27, 2025
@moonbox3 moonbox3 requested a review from a team as a code owner January 27, 2025 05:59
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 27, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/agents/chat_completion
   chat_completion_agent.py110893%85, 87, 90, 99–104, 129, 193
semantic_kernel/agents/open_ai
   azure_assistant_agent.py110496%157, 159, 285, 302
   open_ai_assistant_agent.py111595%152, 154, 268, 288, 307
   open_ai_assistant_base.py5241597%188, 197–202, 282, 298–299, 373–374, 770, 824, 1030, 1038, 1123, 1187
TOTAL17056183489% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3033 4 💤 0 ❌ 0 🔥 1m 22s ⏱️

@moonbox3 moonbox3 added this pull request to the merge queue Jan 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2025
@TaoChenOSU TaoChenOSU added this pull request to the merge queue Jan 28, 2025
Merged via the queue into microsoft:main with commit 1a84cb6 Jan 28, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents python Pull requests for the Python Semantic Kernel
Projects
Archived in project
4 participants