Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Allow enums to be passed in to on_function_result. Improve handling FRC result so it can be hashed. #10316

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

moonbox3
Copy link
Contributor

Motivation and Context

Two topics in this PR:

  • A request to be able to pass in Enums to the Python process on_function_result, instead of just strings.
  • There were some custom types (Pydantic models) that were unable to hash during an agent group chat. One could mark the model frozen so that it is hashable; however, we should add better handling in our code, in case a dev doesn't want to do that.

Description

This PR:

Contribution Checklist

@moonbox3 moonbox3 self-assigned this Jan 28, 2025
@moonbox3 moonbox3 requested a review from a team as a code owner January 28, 2025 07:03
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jan 28, 2025
@github-actions github-actions bot changed the title Allow enums to be passed in to on_function_result. Improve handling FRC result so it can be hashed. Python: Allow enums to be passed in to on_function_result. Improve handling FRC result so it can be hashed. Jan 28, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 28, 2025

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/processes
   process_step_builder.py1102478%45, 94, 108, 115–128, 140–147, 156, 165–175, 180, 220
TOTAL17069183389% 

Python Unit Test Overview

Tests Skipped Failures Errors Time
3042 4 💤 0 ❌ 0 🔥 1m 19s ⏱️

@moonbox3 moonbox3 enabled auto-merge January 28, 2025 20:45
@moonbox3 moonbox3 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into microsoft:main with commit 7e20631 Jan 28, 2025
25 checks passed
@moonbox3 moonbox3 deleted the py-processes-on-func-result-enum branch January 28, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: unhashable type exception for custom return type in kernel function
4 participants