Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: [python] Bug fix 10340 #10341

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Python: [python] Bug fix 10340 #10341

merged 5 commits into from
Jan 31, 2025
+51 −4

Conversation

drdrew42
Copy link
Contributor

Motivation and Context

See #10340

Description

Implement a similar approach as is done in process_step_edge_builder.py, which supports function_name when building the target function.

Contribution Checklist

(well, we're still passing/xpass/xfail the same as main is)

@drdrew42 drdrew42 requested a review from a team as a code owner January 29, 2025 18:02
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label Jan 29, 2025
@github-actions github-actions bot changed the title [python] Bug fix 10340 Python: [python] Bug fix 10340 Jan 29, 2025
moonbox3
moonbox3 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@moonbox3 moonbox3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@moonbox3
Copy link
Contributor

@drdrew42 could you please add a quick unit test so we have coverage? We're lacking test coverage as we're not catching these small items.

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Jan 29, 2025 •
edited
Loading

Python Test Coverage

Python Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL17094186189% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python Unit Test Overview

Tests Skipped Failures Errors Time
3049 4 💤 0 ❌ 0 🔥 1m 22s ⏱️

@drdrew42
Copy link
Contributor Author

@microsoft-github-policy-service agree company="SandboxAQ"

@moonbox3 moonbox3 enabled auto-merge January 30, 2025 23:56
@moonbox3 moonbox3 added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@moonbox3 moonbox3 added this pull request to the merge queue Jan 31, 2025
Merged via the queue into microsoft:main with commit 10c1dfe Jan 31, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moonbox3 moonbox3 moonbox3 approved these changes

@TaoChenOSU TaoChenOSU TaoChenOSU approved these changes

Assignees
No one assigned
Labels
python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drdrew42 @moonbox3 @markwallace-microsoft @TaoChenOSU