-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Avoid sending duplicate function tools when creating a thread #10413
.Net: Avoid sending duplicate function tools when creating a thread #10413
Conversation
8eca04c
to
22a8ead
Compare
Co-authored-by: westey <[email protected]>
dotnet/samples/GettingStartedWithAgents/AzureAIAgents/Step06_AzureAIAgent_Functions.cs
Show resolved
Hide resolved
dotnet/samples/GettingStartedWithAgents/AzureAIAgents/Step06_AzureAIAgent_Functions.cs
Show resolved
Hide resolved
Note: I suspect this issue also exists for assistant API. Because we proxy assistant creation, the path isn't quite as available; although, the exact same dynamic could occur if specifying the agent identifier for an assistant created outside of the framework. |
This is one of the investigations for the declarative file format specification so I'll test this out. |
…10436) ### Motivation and Context Same issue that was fixed here #10413 but this time the fix is for OpenAI Assistants. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Motivation and Context
AzureAIAgent
tools can be specified including function tools. These become part of the Agent definition.AzureAIAgent
we are takingKernelFunction
's and adding them to the list of tool overrides for the Agent. TheKernel
must have all functions that agent can call so it will include function defined when the agent was created. This was leading to an 400 error because the request included duplicate function tools.Description
Contribution Checklist