Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net Agents - Refine client provider/factory #10616

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Feb 19, 2025

Motivation and Context

Move away from the "client-provider" pattern and make client factory more discoverable.

Fixes: #10582

Description

Expose ability to create an SDK client as a static factory methods on the agent. This is more discoverable than poking around for the client-provider and aligns with the Python approach.

  • Organized factory code in a separate file from the core agent abstractions.
  • Updated samples

Contribution Checklist

@crickman crickman added .NET Issue or Pull requests regarding .NET code enhancement agents feature_graduation Applied to all feature graduation issues labels Feb 19, 2025
@crickman crickman self-assigned this Feb 19, 2025
@crickman crickman requested a review from a team as a code owner February 19, 2025 21:07
@github-actions github-actions bot changed the title .NET Agents - Refine client provider/factory .Net Agents - Refine client provider/factory Feb 19, 2025
@crickman crickman requested a review from moonbox3 February 19, 2025 21:08
@crickman crickman requested a review from alliscode February 20, 2025 00:35
@crickman crickman added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
@crickman crickman added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 82aafd3 Feb 20, 2025
19 checks passed
@crickman crickman deleted the agents-discoverable-client-factory branch February 20, 2025 16:27
@crickman crickman mentioned this pull request Feb 21, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents enhancement feature_graduation Applied to all feature graduation issues .NET Issue or Pull requests regarding .NET code
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

.Net: include directions on how to create AzureAIClientProvider using FromConnectionString for AzureAIAgent
3 participants