.Net: Update to the latest MEAI and OpenAI packages #13181
Conversation
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I was about to do this. Thanks. |
dotnet/Directory.Packages.props
Outdated
| <PackageVersion Include="OData2Linq" Version="2.2.0" /> | ||
| <PackageVersion Include="OllamaSharp" Version="5.3.5" /> | ||
| <PackageVersion Include="OpenAI" Version="[2.4.0]" /> | ||
| <PackageVersion Include="OpenAI" Version="[2.5.0]" /> |
There was a problem hiding this comment.
Why do we have this pinned to one specific version? If it's allowed to float forward, there's at least a chance that if OpenAI takes a binary breaking change things will still work. If it's pinned, there's zero chance.
There was a problem hiding this comment.
I tracked it down to this PR - #8978 that explains the reason "Pins OpenAI and Azure OpenAI packages to fixed beta releases so that the NuGet constraint is now == rather than >=, avoiding issues with beta releases and breaking changes."
There was a problem hiding this comment.
avoiding issues with beta releases and breaking changes
But it causes issues for consumers. If someone is referencing SK and another library that references a newer version of OpenAI, that consumer simply can't build, period.
There was a problem hiding this comment.
Changed to "2.5.0".
There was a problem hiding this comment.
I wonder whether we do the same for Azure.AI.OpenAI package that is pinned to [2.3.0-beta.2] at the moment?
There was a problem hiding this comment.
OpenAI takes a binary breaking change things will still work
The biggest concern is not related to OpenAI changes, but rather with Azure.AI.OpenAI breaking due to changes in OpenAI versions.
But it causes issues for consumers. If someone is referencing SK and another library that references a newer version of OpenAI, that consumer simply can't build, period.
IMO allowed to float forward becomes very problematic when we have beta versions from Azure.AI.OpenAI that only works for a specific OpenAI GA version and when any mixing happens due to external combinations we start getting many issues of Method not Found that in reality are unrelated to Semantic Kernel code-base issues.
One important point though is that we stopped getting issues related to the mixing after we locked the versions and I would prefer changing this only if we started to get issues related to Can't build.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
No description provided.