Skip to content

.Net: Fix #13183: .NET — Kernel.AddOpenAIChatClient throws an error when us… #13198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+29 −7
Open

.Net: Fix #13183: .NET — Kernel.AddOpenAIChatClient throws an error when us… #13198

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cec06af
Fix #13183: .NET — Kernel.AddOpenAIChatClient throws an error when us…
iangithub Sep 30, 2025
8ea9ba6
Update dotnet/src/Connectors/Connectors.OpenAI/Extensions/OpenAIServi…
iangithub Oct 3, 2025
5f8a62c
Update dotnet/src/Connectors/Connectors.OpenAI/Extensions/OpenAIServi…
iangithub Oct 3, 2025
481420f
Corrected the naming of the HttpClient variable in the AddOpenAIChatC…
iangithub Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions ...ors/Connectors.OpenAI/Extensions/OpenAIServiceCollectionExtensions.DependencyInjection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,12 @@ IChatClient Factory(IServiceProvider serviceProvider, object? _)
{
var loggerFactory = serviceProvider.GetService<ILoggerFactory>();

ClientCore.GetOpenAIClientOptions(
endpoint: null,
orgId: orgId,
httpClient: HttpClientProvider.GetHttpClient(httpClient, serviceProvider));

var builder = new OpenAIClient(
credential: new ApiKeyCredential(apiKey ?? SingleSpace),
options: ClientCore.GetOpenAIClientOptions(HttpClientProvider.GetHttpClient(httpClient, serviceProvider)))
options: ClientCore.GetOpenAIClientOptions(
httpClient: HttpClientProvider.GetHttpClient(httpClient, serviceProvider),
endpoint: null,
orgId: orgId))
.GetChatClient(modelId)
.AsIChatClient()
.AsBuilder()
Expand Down Expand Up @@ -153,10 +151,34 @@ IChatClient Factory(IServiceProvider serviceProvider, object? _)
{
var loggerFactory = serviceProvider.GetService<ILoggerFactory>();

// Get or create HttpClient with proper BaseAddress for the endpoint
HttpClient innerHttpClient;
if (httpClient is not null)
{
innerHttpClient = httpClient;
}
else
{
var defaultClient = HttpClientProvider.GetHttpClient(serviceProvider);
// If using default client and it doesn't have BaseAddress set, create one with the endpoint
if (defaultClient.BaseAddress is null)
{
Verify.NotNull(endpoint);

// A new one needs to be created as we can't cross boundaries and modify an existing client
innerHttpClient = HttpClientProvider.GetHttpClient();
innerHttpClient.BaseAddress = endpoint;
}
else
{
innerHttpClient = defaultClient;
}
}

var builder = new OpenAIClient(
credential: new ApiKeyCredential(apiKey ?? SingleSpace),
options: ClientCore.GetOpenAIClientOptions(
httpClient: HttpClientProvider.GetHttpClient(httpClient, serviceProvider),
httpClient: innerHttpClient,
endpoint: endpoint,
orgId: orgId))
.GetChatClient(modelId)
Expand Down