-
Notifications
You must be signed in to change notification settings - Fork 83
Add banner color text picker to admin settings #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Bionic711 <[email protected]>
Co-authored-by: Copilot <[email protected]>
(cherry picked from commit 09a214f)
|
@wingmann2 |
@microsoft-github-policy-service agree company="Microsoft" |
@Bionic711 Adding settings to funcitons_settings.py . Noticed there was also missing classification settings for related background color and default text that was not referenced before. |
|
@wingmann2 I have requested the Copilot review. Resolve out the two conflicts and once the Copilot review is done, we can merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a text color picker for the classification banner to improve readability when using light background colors. The hardcoded white text color (#fff) is replaced with a user-configurable option that defaults to white (#ffffff) for backward compatibility.
Key Changes:
- Added a new color picker input field for banner text color in admin settings
- Updated the classification banner display to use the configurable text color
- Set default text color to
#ffffffacross all configuration files
Additional Change:
- Fixed an unrelated bug in
admin_plugins.jswhere the plugins modal failed to load with sidenav navigation
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| application/single_app/templates/base.html | Updated banner inline style to use configurable text color instead of hardcoded #fff |
| application/single_app/templates/admin_settings.html | Added text color picker input field, updated preview to display selected text color, and added JavaScript to handle text color in preview |
| application/single_app/static/js/admin/admin_plugins.js | Fixed DOM element check from agents-tab to actions-configuration for sidenav compatibility |
| application/single_app/route_frontend_admin_settings.py | Added extraction and storage of banner text color from form data with #ffffff default |
| application/single_app/functions_settings.py | Added default value for classification_banner_text_color in settings |
| application/single_app/config.py | Incremented version from 0.229.062 to 0.229.063 |
| application/external_apps/databaseseeder/artifacts/admin_settings.json | Added classification_banner_text_color field with #ffffff default to seeder data |
| RELEASE_NOTES.md | Added release notes for v0.229.063 documenting the admin plugins modal fix |
Comments suppressed due to low confidence (1)
application/single_app/templates/admin_settings.html:2878
- The JavaScript event listener for
textColorInputis missing. While thetextColorInputelement is retrieved and used in theupdatePreview()function, there's no event listener attached to it. This means the preview won't update when the user changes the text color.
Add an event listener for the text color input:
if (textInput && colorInput && preview) {
textInput.addEventListener('input', updatePreview);
colorInput.addEventListener('input', updatePreview);
textColorInput.addEventListener('input', updatePreview); // Add this line
} if (textInput && colorInput && preview) {
textInput.addEventListener('input', updatePreview);
colorInput.addEventListener('input', updatePreview);
}
Co-authored-by: Copilot <[email protected]>
* fix video indexer auth
* fixed video indexer support
* fixed video indexer support
* fix video indexer support
* fixed video indexer support
* added support for .xlsm
* fixed all scope issue
* added supprot for xml, yaml, and log
#### **JSON**
- Uses `RecursiveJsonSplitter`:
- `max_chunk_size=600`
- `convert_lists=True`
- Produces JSON strings that retain original structure.
- See `process_json_file`.
#### **XML**
- Uses `RecursiveCharacterTextSplitter` with XML-aware separators.
- **Structure-preserving chunking**:
- Separators prioritized: `\n\n` → `\n` → `>` (end of XML tags) → space → character
- Splits at logical boundaries to maintain tag integrity
- **Chunked by 4000 characters** with 200-character overlap for context preservation.
- **Goal**: Preserve XML structure while providing manageable chunks for LLM processing.
- See `process_xml`.
#### **YAML / YML**
- Processed using regex word splitting (similar to TXT).
- **Chunked by 400 words**.
- Maintains YAML structure through simple word-based splitting.
- See `process_yaml`.
#### **LOG**
- Processed using line-based chunking to maintain log record integrity.
- **Never splits mid-line** to preserve complete log entries.
- **Line-Level Chunking**:
1. Split file by lines using `splitlines(keepends=True)` to preserve line endings.
2. Accumulate complete lines until reaching target word count ≈1000 words.
3. When adding next line would exceed target AND chunk already has content:
- Finalize current chunk
- Start new chunk with current line
4. If single line exceeds target, it gets its own chunk to prevent infinite loops.
5. Emit chunks with complete log records.
- **Goal**: Provide substantial log context (1000 words) while ensuring no log entry is split across chunks.
- See `process_log`.
* updated yaml to use recursivesplitter
* removed chunk overlap for yaml and xml
* added support for older .doc files and .docm
* added keyword and abstract for each doc in citation
* added multi-modal input support
* added ai vision analysis
|
@wingmann2, unfortunately, I cannot resolve the conflicts via the browser, please review them. If you have any questions, let me know. Im around Mon-Wed this week. |
@paullizer I can't either, although it says changes can be cleanly merged. Between forks and upkeeping sources it makes conflicts difficult. May I be added to the contributor status for this project to be able to maintain branches directly without forking? |
|
You resolve the conflicts in your local branch and push them. The PR will pick up on them and then we will be able to merge. The best way, in my opinion given the files, would be to rebase your branch onto Development. Accept the incoming changes where appropriate (or both if needed). Let me know if you need assistance with the rebase. A merge would also solve the problem, but will muddy the commit history. |
When picking a color for the classification banner, this is always set to white as hardcoded value "#fff". When selecting certain color shades (ex. bright yellow) this banner is unreadable. This change would allow the user to select the color of the text to go along with the paired background color. This may be typically white or black, however this picker allows the user more flexibility with styling and further compliance.