Add display name and icon to SUI extensions page #18633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
|
carlos-zamora
commented
Feb 27, 2025
src/cascadia/TerminalSettingsModel/PowershellCoreProfileGenerator.cpp
Outdated
Show resolved
Hide resolved
| @@ -28,6 +28,8 @@ namespace winrt::Microsoft::Terminal::Settings::Model | |||
| public: | |||
| static std::wstring_view Namespace; | |||
| std::wstring_view GetNamespace() const noexcept override; | |||
| std::wstring_view GetDisplayName() const noexcept override; | |||
| std::wstring_view GetIcon() const noexcept override { return {}; }; | |||
There was a problem hiding this comment.
The only icons I found here were one for PowerShell and one for CMD. Can we get a Visual Studio asset for here?
Comment on lines
+391
to
+424
| <!-- | ||
| BODGY | ||
| Theoretically, you could use a ContentTemplateSelector directly. However, that doesn't work. | ||
| For some reason, we just get the object type's ToString called and the selector gets nullptr as a parameter. | ||
| Adding the template as a view model property is a workaround. | ||
| --> |
There was a problem hiding this comment.
📝 FYI, I spent like most of today figuring out how to work around this. Frustrating 😡
| @@ -119,17 +119,19 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation | |||
| _extensionsVM = *extensionsVMImpl; | |||
| _extensionsViewModelChangedRevoker = _extensionsVM.PropertyChanged(winrt::auto_revoke, [=](auto&&, const PropertyChangedEventArgs& args) { | |||
| const auto settingName{ args.PropertyName() }; | |||
| if (settingName == L"CurrentExtensionSource") | |||
There was a problem hiding this comment.
📝 All the changes in this file are really just because I switched from CurrentExtensionSource to CurrentExtensionPackage. Honestly, it's better this way imo. It aligns better with how the New Tab Menu works as well as the other subpages for profiles
| @@ -42,7 +42,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation | |||
| WINRT_OBSERVABLE_PROPERTY(Editor::NewTabMenuViewModel, ViewModel, _PropertyChangedHandlers, nullptr); | |||
|
|
|||
| private: | |||
| Editor::NewTabMenuEntryTemplateSelector _entryTemplateSelector{ nullptr }; | |||
There was a problem hiding this comment.
📝Drive by. We weren't using it at all.
|
CC @nguyen-dows and @DHowett for some of the questions above. Y'all may know where I can find some of these assets |
carlos-zamora
force-pushed
the
dev/cazamor/sui/extensions-page
branch
from
ec88b32 to
7cdbb7c
Compare
carlos-zamora
force-pushed
the
dev/cazamor/sui/ext-page/beautify
branch
from
f780523 to
cb04e7f
Compare
lhecker
reviewed
Mar 11, 2025
This comment was marked as outdated.
This comment was marked as outdated.
DHowett
requested changes
Apr 16, 2025
src/cascadia/TerminalSettingsModel/AzureCloudShellGenerator.cpp
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
|
Updated icons: |
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds some polish to the Extensions page in the Settings UI. This includes:
References and Relevant Issues
Targets #18559
Detailed Description of the Pull Request / Additional comments
DisplayNameandIcontoIDynamicProfileGeneratorDisplayNameandIconfrom app extensions and use themExtensionPackageis a new WinRT class to package a bunch ofFragmentSettingstogetherExtensionPackages rather than dynamically adding/removingFragmentSettings contentsCurrentExtensionSourcewithCurrentExtensionPackageExtensionPackageTemplateSelectoris used to displayExtensionPackages with metadata vs simple ones that just have a sourceValidation
✅ Keyboard navigation feels right
✅ Screen reader reads all info on screen properly
✅ Accessibility Insights FastPass found no issues
✅ "Discard changes" retains subpage, but removes any changes