Avoid keeping trx stream open in unit tests #4642
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrxTests works by creating a MemoryStream, and mocking NewFileStream to return that instance. Then later, the tests tries to use that stream. For that reason, tests are passing a flag to prevent production code form disposing the stream.
This PR cleans up product code, but makes tests more verbose. Now, product code will always dispose, without any flag that's used by tests. However, the "fake" stream created by tests will create the
XDocument
that the test needs when Dispose is called. That way, we don't need the stream anymore and we use the XDocument.@Evangelink How do you feel about this change? I generally don't like when there is a code path in product code that's test only and prefer more ugly tests but cleaner product code. That's a personal taste though.