-
Notifications
You must be signed in to change notification settings - Fork 457
Deprecate AugmentationSequential wrapper #2396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate AugmentationSequential wrapper #2396
Conversation
It looks like NASA Marine Debris and VHR-10 data modules still use the deprecated wrapper? |
I prefer just removing it tbh. But I would like to verify kornia's augmentations work as expected for the detection datasets before that.
Yeah, I was planning to have the object detection datasets switch to Kornia's |
Gotcha, will mark this as a draft and wait on #1978 |
205c6a8
to
ed54469
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight preference for just removing it as we will definitely want to remove it later
Let's just deprecate it for now. It's only a couple lines of code, it isn't hurting anyone. I think everyone has been using our wrapper up until now, we don't want all of their code to break. |
* Deprecate AugmentationSequential wrapper * Test deprecation * Remove tests for deprecated wrapper
Thoughts on whether we should deprecate this or just remove it? It's been deprecated since 0.4, but also we've been using it continuously since then. We're moving towards a 1.0 release in the future after which we'll need to start formally deprecating things anyway.