Implemented single character insertion and deletion#199
Open
Implemented single character insertion and deletion#199
Conversation
gabritto
reviewed
Feb 25, 2026
Member
gabritto
left a comment
gabritto
left a comment
There was a problem hiding this comment.
Code looks ok to me, but I left some suggestions for consideration. Excited to try this out!
| else if (serverCharacter > 0) { | ||
| // Delete previous character | ||
| documentVersion++; | ||
| await notify("textDocument/didChange", { |
Member
There was a problem hiding this comment.
Maybe we should try to bit somewhat smarter about deletion in order to get closer to scenarios where someone is halfway through typing/editing code? e.g. delete the rest of the line, delete ending parentheses/braces, etc.
Contributor
Author
There was a problem hiding this comment.
Good idea! I'll add a case for deleting the rest of the line, and I'll increase the probability of deletion if the character is a brace/dot/similar punctuation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.