Skip to content

refactor: remove unused parameter from tryInvokeWildCardDirectories #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove unused parameter from tryInvokeWildCardDirectories #1594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/project/configfileregistry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func (c *ConfigFileRegistry) onConfigChange(path tspath.Path, changeKind lsproto
return true
}

func (c *ConfigFileRegistry) tryInvokeWildCardDirectories(fileName string, path tspath.Path) {
func (c *ConfigFileRegistry) tryInvokeWildCardDirectories(fileName string) {
configFiles := c.ConfigFiles.ToMap()
for configPath, entry := range configFiles {
entry.mu.Lock()
Expand Down
4 changes: 2 additions & 2 deletions internal/project/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ func (s *Service) OpenFile(fileName string, fileContent string, scriptKind core.
s.openFiles[info.path] = projectRootPath
if existing == nil && info != nil && !info.isDynamic {
// Invoke wild card directory watcher to ensure that the file presence is reflected
s.configFileRegistry.tryInvokeWildCardDirectories(fileName, info.path)
s.configFileRegistry.tryInvokeWildCardDirectories(fileName)
}
result := s.assignProjectToOpenedScriptInfo(info)
s.cleanupProjectsAndScriptInfos(info, result)
Expand Down Expand Up @@ -331,7 +331,7 @@ func (s *Service) OnWatchedFilesChanged(ctx context.Context, changes []*lsproto.
for _, project := range s.inferredProjects {
project.onWatchEventForNilScriptInfo(fileName)
}
s.configFileRegistry.tryInvokeWildCardDirectories(fileName, path)
s.configFileRegistry.tryInvokeWildCardDirectories(fileName)
}
}

Expand Down
Loading