-
Notifications
You must be signed in to change notification settings - Fork 708
Port rename test + baseline fixes #1714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
219e300
Add missing ast.IsVariableDeclarationList test
ahejlsberg 1288cdc
Handle rename in fourslash converter + skeleton verification functions
ahejlsberg fc64898
WIP: baselineRename
gabritto 9118e60
port baseline rename tests
gabritto 719ae9b
temporarily accept all baselines
gabritto 5c32809
WIP: verify baselines during cleanup to handle multiple baseline calls
gabritto 4047497
WIP: re-split baseline files per command
gabritto 0983fa7
blank line fix for baselines, setup diffing for rename baselines
gabritto f5e8c7a
fix marker position in baselines
gabritto b0eba8b
more fixes
gabritto 99c2f67
more fixes
gabritto 2ff410d
accept baselines
gabritto 62ad46c
update failing tests
gabritto 0fb1a46
update makeManual
gabritto b723a67
improvements: rename info failed, parse rename preferences
gabritto fe0ca4a
add user preferences argument
gabritto 0e15b6a
refactor
gabritto 0814695
Merge branch 'main' into fourslash-rename
gabritto 7dccc62
format
gabritto b91d0c9
delete unused baselines
gabritto fd226a3
fix casing in baseline files
gabritto 66af090
skip fourslash if no submodule
gabritto 75efe46
manually ported test
gabritto 5c70193
Merge branch 'gabritto/fourslash-rename' of https://github.com/micros…
gabritto 4f015c7
only trim CR
gabritto 0093174
normalize command name for test output files
gabritto 46d95f2
update baselines
gabritto 46c7124
Merge branch 'main' into gabritto/fourslash-rename
gabritto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.