Add symbol baseliner #191
Merged
Add symbol baseliner #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabritto
commented
Dec 17, 2024
| @@ -19,12 +19,6 @@ import ( | |||
| // IO | |||
| const harnessNewLine = "\r\n" | |||
|
|
|||
| var ( | |||
There was a problem hiding this comment.
Moved to internal/testutil/baseline/util.go
gabritto
commented
Jan 6, 2025
| @@ -1123,7 +1123,7 @@ func IsDeclaration(node *Node) bool { | |||
|
|
|||
| // True if `name` is the name of a declaration node | |||
| func IsDeclarationName(name *Node) bool { | |||
| return !IsSourceFile(name) && !IsBindingPattern(name) && IsDeclaration(name.Parent) | |||
| return !IsSourceFile(name) && !IsBindingPattern(name) && IsDeclaration(name.Parent) && name.Parent.Name() == name | |||
gabritto
commented
Jan 6, 2025
| @@ -15,11 +15,11 @@ type Options struct { | |||
|
|
|||
| const NoContent = "<no content>" | |||
|
|
|||
| func Run(t testing.TB, fileName string, actual string, opts Options) { | |||
| func Run(t *testing.T, fileName string, actual string, opts Options) { | |||
There was a problem hiding this comment.
Had to make this change from testing.TB to testing.T because I wanted to use t.Run in one symbol baseline function and so I changed it everywhere else, too.
gabritto
commented
Jan 6, 2025
| @@ -253,19 +246,6 @@ func iterateErrorBaseline(t testing.TB, inputFiles []*TestFile, inputDiagnostics | |||
| return result | |||
| } | |||
|
|
|||
| func checkDuplicatedFileName(resultName string, dupeCase map[string]int) string { | |||
There was a problem hiding this comment.
I realized this was essentially unused in the old test infra.
jakebailey
reviewed
Jan 7, 2025
|
Is there a test we could write for this "now" to verify that it works? |
|
Ah, #115 seems to include it. |
jakebailey
reviewed
Jan 7, 2025
Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
jakebailey
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.