Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env variable for installer path for Unity #111 #127

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

add env variable for installer path for Unity #111 #127

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b8da9c
add env variable for installer path for Unity #111
abhinuvpitale Oct 8, 2018
b5b2262
update for adding user env path
abhinuvpitale Oct 8, 2018
57b650b
changed position. Set only if successful
abhinuvpitale Oct 9, 2018
325a245
changed `$version`
abhinuvpitale Oct 9, 2018
164441f
changed `$version` and `$destPath`
abhinuvpitale Oct 11, 2018
470c236
cached localVersion, added to update
abhinuvpitale Oct 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion UnitySetup/UnitySetup.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,9 +489,10 @@ function Install-UnitySetupInstance {
}
else {
Write-Verbose "$(Get-Date): Succeeded."
[Environment]::SetEnvironmentVariable("UNITY_$($i.Version)", $Destination, [System.EnvironmentVariableTarget]::User)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, $i.Version is empty string at this point since we're in a different loop from above. You'll need to cache that string for this install process later. Are you having issues testing locally to verify this code works?

In my macOS PR this entire flow is changing and should be easier to get the correct version for this.

}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra white space trailing the end here isn't needed.

}
}

Expand Down