Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print Auth token when in Verbose mode #275

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Only print Auth token when in Verbose mode #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UnitySetup/UnitySetup.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2824,7 +2824,7 @@ function Update-UnityPackageManagerConfig {
}

Write-Verbose "Summary"
Write-Output $upmConfigs
Write-Verbose $upmConfigs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should either skip the summary or strip the tokens from the objects. Even in verbose it's not good practice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note - Write-Output is like adding it to the return value. It'll only get printed if the caller doesn't capture the output. That said, I agree that I think the author was trying to print this out for the summary not return it.

}

if ($VerifyOnly) {
Expand Down