Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binarycaching.md: Move Configuration section to the top. Add table of… #17060

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

autoantwort
Copy link
Contributor

… contents. Make clear that file location must be absolute. Add that read is the default mode.

Describe the pull request

  • What does your PR fix?
    The most important part should be at the top, add that the file location must be absolute and that the "read" mode is the default one.

… contents. Make clear that file location must be absolute. Add that read is the default mode.
@JackBoosY JackBoosY self-assigned this Apr 5, 2021
@JackBoosY JackBoosY added the category:documentation To resolve the issue, documentation will need to be updated label Apr 5, 2021
@JackBoosY JackBoosY requested a review from ras0219-msft April 5, 2021 06:37
docs/users/binarycaching.md Outdated Show resolved Hide resolved
docs/users/binarycaching.md Outdated Show resolved Hide resolved
docs/users/binarycaching.md Show resolved Hide resolved
docs/users/binarycaching.md Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 15, 2021
@strega-nil-ms
Copy link
Contributor

strega-nil-ms commented Apr 30, 2021

I'd like a green review from @ras0219 / @ras0219-msft before merging

@ras0219-msft ras0219-msft merged commit 44d94c2 into microsoft:master Apr 30, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

@autoantwort autoantwort deleted the bin-cache-docs branch September 1, 2021 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants