[miniupnpc] Update to 2.3.0 #43233
Open
[miniupnpc] Update to 2.3.0 #43233
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MonicaLiu0311
added
info:internal
7 tasks
MonicaLiu0311
commented
Jan 13, 2025
Comment on lines
-4
to
+5
| "git-tree": "7cd06d47cb0cbaf659be8195bf06f2aef1980746", | ||
| "version": "2.3.7", | ||
| "git-tree": "1df0846b7dbe04a4f9904be58d30759b16f119f0", | ||
| "version": "2.3.0", |
There was a problem hiding this comment.
The removal was done because there is no 2.3.7 version on the miniupnpc branch.
|
AFAIU manifest mode version constraints are broken for |
Yes, it happens during this period... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40552. Update
miniupnpcto 2.3.0.No feature needs to be tested, the usage test succesfully on x64-windows(header file found).
In PR #40552, I changed
REF "miniupnpc_${MINIUPNPC_VERSION}"to"miniupnpd_${MINIUPNPC_VERSION}". I forgot the reason, it may be a mistake, I'm sorry. The good thing is that I found thatminiupnpchas no upstream or downstream in vcpkg, and there has been no related issues since PR #40552, so it can be assumed that it has not affected any other ports and users during this period. Sorry again.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.