Rewrite C++ API#67
Open
mjp41 wants to merge 4 commits into
Open
Conversation
Use the final parameter to `when` as the closure to call. This simplifies various parts of the C++ API, and have a, hopefully, easier to follow code structure.
Member
Author
|
I'd recommend reading when.h not as a diff, but just as is. The changes are too much for a diff to make sense. |
The staging of the move was occuring too early and making the cown null. I guess there was a subtle UB here.
marioskogias
approved these changes
Jun 3, 2025
marioskogias
left a comment
marioskogias
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Everything is so much cleaner now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the final parameter to
whenas the closure to call. This simplifies various parts of the C++ API, and have a, hopefully, easier to follow code structure.