Open
Conversation
Co-authored-by: alexweininger <[email protected]>
Co-authored-by: alexweininger <[email protected]>
Copilot
AI
changed the title
[WIP] Create v2 storage account using extension
Use StorageV2 for storage account creation
Jan 21, 2026
nturinski
approved these changes
Jan 22, 2026
Member
nturinski
left a comment
There was a problem hiding this comment.
Actually, I think that this works. From the StorageAccountListStep
export declare class StorageAccountListStep<T extends IStorageAccountWizardContext> extends AzureWizardPromptStep<T> {
/**
* @param createOptions Default options to use when creating a Storage Account
* @param filterOptions Optional filters used when listing Storage Accounts
*/
public constructor(createOptions: INewStorageAccountDefaults, filterOptions?: IStorageAccountFilters);
So just changing the kind should make it so we create V2 by default.
Contributor
|
@copilot don't make any changes to |
Co-authored-by: MicroFish91 <[email protected]>
Contributor
Author
Member
After the esbuild conversion, we'll never have to do that again. |
bwateratmsft
approved these changes
Jan 27, 2026
MicroFish91
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Storage Account Creation from v1 to v2
The extension currently creates v1 storage accounts, which have been retired. This PR updates the extension to create v2 (StorageV2) storage accounts instead.
Changes Made:
StorageAccountKind.Storage(v1) is usedStorageAccountKind.StoragewithStorageAccountKind.StorageV2in:src/commands/createFunctionApp/createCreateFunctionAppComponents.ts(line 51)src/commands/appSettings/connectionSettings/azureWebJobsStorage/StorageConnectionListStep.ts(line 77)src/commands/addBinding/settingSteps/StorageTypePromptStep.ts(line 43)main.jsTechnical Details:
Changed
StorageAccountKind.StoragetoStorageAccountKind.StorageV2in all storage account creation configurations. This ensures that when users create new storage accounts through the extension, they will be v2 (general-purpose v2) storage accounts instead of v1 (general-purpose v1) storage accounts.Verification:
Summary:
This is a minimal, surgical change that updates only the storage account kind from v1 to v2. All other configuration parameters (Standard performance, LRS replication) remain unchanged. The change affects three key areas: Function App creation, storage connection settings, and binding settings.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.