-
Notifications
You must be signed in to change notification settings - Fork 150
Auto-open mcp.json after Self-Hosted MCP Server project creation #4902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
main
Choose a base branch
from
copilot/open-mcp-json-automatically
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−3
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
89094a2
Initial plan
Copilot eac6330
Add MCPOpenFileStep to automatically open mcp.json after Self-Hosted …
Copilot df5cbf7
Fix shouldExecute to check workspace folders for AddToWorkspace behavior
Copilot 857899a
Add copyright header to MCPOpenFileStep.ts
Copilot 2a085b2
Refactor to use runPostMcpProjectCreateSteps pattern similar to runPo…
Copilot 2676a90
Remove unnecessary return statement
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
src/commands/createNewProject/mcpServerSteps/MCPOpenFileStep.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| * Licensed under the MIT License. See License.txt in the project root for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import { AzExtFsExtra, AzureWizardExecuteStep } from '@microsoft/vscode-azext-utils'; | ||
| import * as path from 'path'; | ||
| import { Uri, window, workspace } from 'vscode'; | ||
| import { type MCPProjectWizardContext } from '../IProjectWizardContext'; | ||
|
|
||
| export class MCPOpenFileStep extends AzureWizardExecuteStep<MCPProjectWizardContext> { | ||
| public priority: number = 240; // Execute before OpenFolderStep (priority 250) but after other project setup | ||
|
|
||
| public async execute(context: MCPProjectWizardContext): Promise<void> { | ||
| const mcpJsonFilePath: string = path.join(context.projectPath, '.vscode', 'mcp.json'); | ||
|
|
||
| if (await AzExtFsExtra.pathExists(mcpJsonFilePath)) { | ||
| const mcpJsonFile = await workspace.openTextDocument(Uri.file(mcpJsonFilePath)); | ||
| await window.showTextDocument(mcpJsonFile, { preview: false }); | ||
| } | ||
| } | ||
|
|
||
| public shouldExecute(context: MCPProjectWizardContext): boolean { | ||
| // Only execute if we're not opening the folder in a way that would reload the window | ||
| // If opening in current window or new window, the file open would be lost during reload | ||
| const openFolders = workspace.workspaceFolders || []; | ||
|
|
||
| // Handle AddToWorkspace: only if there are existing workspace folders | ||
| // (OpenFolderStep changes AddToWorkspace to OpenInCurrentWindow if no folders exist) | ||
| if (context.openBehavior === 'AddToWorkspace') { | ||
| return openFolders.length > 0; | ||
| } | ||
|
|
||
| // Always execute for these cases | ||
| return context.openBehavior === 'AlreadyOpen' || | ||
| context.openBehavior === 'DontOpen'; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.