Skip to content

Comments

Support for domain name label scopes#4909

Open
MicroFish91 wants to merge 11 commits intomainfrom
mwf/default-hostname
Open

Support for domain name label scopes#4909
MicroFish91 wants to merge 11 commits intomainfrom
mwf/default-hostname

Conversation

@MicroFish91
Copy link
Contributor

@MicroFish91 MicroFish91 commented Feb 5, 2026

Closes #4889

TODO:

  • Add telemetry
  • Tests in separate PR

One oddity I had to handle here is that the full site isn’t initialized yet when we first fetch resources, so I have to rely on the data model location returned by MS Graph (see westus and westus2). You’ll notice this location format differs from what we get when fetching directly from the ARM endpoint. Containerized Functions already doesn't lazy load for other reasons so we could certainly do something similar (see the app with Central US location format).

I could make additional ARM calls to retrieve the full site envelope and normalize the location format, but that would impact performance since it would no longer be lazily loaded. I chose to skip the extra fetches to preserve performance. In practice, the location is only needed to show when sites share the same name but are deployed to different regions. Another option is to keep a map of equivalent prettified versions of the locations, but I don't want us to have to manage that. My vote is just to keep this as-is.

image

@MicroFish91 MicroFish91 marked this pull request as ready for review February 9, 2026 19:49
@MicroFish91 MicroFish91 requested a review from a team as a code owner February 9, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for domain name label scopes

2 participants