This repository was archived by the owner on Nov 30, 2023. It is now read-only.
Add docker-in-docker Azure DNS override flag #1650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CleanCut
approved these changes
Oct 5, 2022
joshspicer
reviewed
Oct 6, 2022
joshspicer
reviewed
Oct 6, 2022
There was a problem hiding this comment.
Thank you for improving our scripts!
As @samruddhikhandale mentioned, it would be great to additionally put up a PR on the associated Feature, as we have deprecated these scripts in favor of the new Features repo. The script in the Features repo should be nearly identical.
In the Features repo, you'd want to update both the install script and add in a new AzureDnsOverride option so that we can surface this flag in tooling
joshspicer
reviewed
Oct 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the docker-in-docker script passes an Azure specific IP address to dockerd that causes Docker not to use the devcontainer's resolv.conf settings. We would like to not override DNS within Docker in some situations.
This PR adds a new
AZURE_DNS_OVERRIDEflag that will give us the ability to disable this Azure DNS setting.