Skip to content

Pass feedBaseUrl to NPM release template for internal feed publish#375

Merged
bwateratmsft merged 1 commit into
mainfrom
bwateratmsft/feedbaseurl-release-param
Jun 18, 2026
Merged

Pass feedBaseUrl to NPM release template for internal feed publish#375
bwateratmsft merged 1 commit into
mainfrom
bwateratmsft/feedbaseurl-release-param

Conversation

@bwateratmsft

Copy link
Copy Markdown
Collaborator

Adds the feedBaseUrl parameter to the NPM release pipeline config so the released tarball is also published to the internal Azure Artifacts feed (after the ESRP publish to npmjs.org).

In .config/release.yml, passes feedBaseUrl: ${{ variables.feedBaseUrl }} to the azdo-pipelines/1es-mb-release-npm.yml@azExtTemplates template. feedBaseUrl is already provided by the shared azdo-pipelines/azcode.variables.yml@azExtTemplates template, so no other change is needed.

This pairs with a companion change in microsoft/vscode-azuretools that makes the NPM release template also publish to the internal feed.

⚠️ Must stay a DRAFT until the vscode-azuretools template change is released to azext-pt/v1. This repo consumes the template at ref: azext-pt/v1, which does not yet have the feedBaseUrl parameter. Merging before the template is released would cause the pipeline to fail to compile on the unknown parameter.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bwateratmsft bwateratmsft marked this pull request as ready for review June 18, 2026 20:03
@bwateratmsft bwateratmsft requested a review from a team as a code owner June 18, 2026 20:03
Copilot AI review requested due to automatic review settings June 18, 2026 20:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure DevOps NPM release pipeline configuration to forward feedBaseUrl into the shared vscode-azuretools NPM release template, enabling post-ESRP publish to an internal Azure Artifacts feed once the upstream template supports it.

Changes:

  • Passes feedBaseUrl: ${{ variables.feedBaseUrl }} into the azdo-pipelines/1es-mb-release-npm.yml@azExtTemplates template in .config/release.yml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .config/release.yml
@bwateratmsft bwateratmsft merged commit 836b37e into main Jun 18, 2026
3 checks passed
@bwateratmsft bwateratmsft deleted the bwateratmsft/feedbaseurl-release-param branch June 18, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants