Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Toolkit docs migration #7827

Open
wants to merge 72 commits into
base: main
Choose a base branch
from
Open

Conversation

sffamily
Copy link

No description provided.

@ntrogh ntrogh self-requested a review December 2, 2024 09:51
@ntrogh ntrogh self-assigned this Dec 2, 2024
Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sffamily First iteration of reviews. Once you've dealt with this, I'll do another more in-depth review.

docs/intelligentapps/get_started.md Outdated Show resolved Hide resolved
docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/finetune.md Show resolved Hide resolved
docs/intelligentapps/finetune.md Show resolved Hide resolved
docs/intelligentapps/finetune.md Outdated Show resolved Hide resolved
docs/intelligentapps/finetune.md Outdated Show resolved Hide resolved
docs/intelligentapps/finetune.md Outdated Show resolved Hide resolved
@sffamily
Copy link
Author

@ntrogh I just went through and addressed all your 1st pass comments. In addition I added 2 new pages for features we are releasing this week. Also did some minor updates of contents. Please help review.

Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sffamily more feedback

docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/overview.md Show resolved Hide resolved
docs/intelligentapps/overview.md Outdated Show resolved Hide resolved
docs/intelligentapps/evaluation.md Outdated Show resolved Hide resolved
docs/intelligentapps/evaluation.md Outdated Show resolved Hide resolved
docs/intelligentapps/evaluation.md Outdated Show resolved Hide resolved
docs/intelligentapps/evaluation.md Outdated Show resolved Hide resolved
docs/intelligentapps/evaluation.md Show resolved Hide resolved
sffamily and others added 15 commits December 17, 2024 12:52
@sffamily
Copy link
Author

@ntrogh I've updated and addressed all round 2 comments. pls help review.

Copy link
Contributor

@ntrogh ntrogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sffamily Thanks for the updates. Just a couple small updates remaining.

docs/intelligentapps/bulkrun.md Outdated Show resolved Hide resolved
docs/intelligentapps/bulkrun.md Outdated Show resolved Hide resolved
docs/intelligentapps/bulkrun.md Outdated Show resolved Hide resolved
docs/intelligentapps/bulkrun.md Outdated Show resolved Hide resolved
docs/intelligentapps/bulkrun.md Outdated Show resolved Hide resolved
docs/intelligentapps/evaluation.md Show resolved Hide resolved
docs/intelligentapps/evaluation.md Outdated Show resolved Hide resolved
docs/intelligentapps/evaluation.md Outdated Show resolved Hide resolved
docs/intelligentapps/models.md Outdated Show resolved Hide resolved
docs/intelligentapps/models.md Outdated Show resolved Hide resolved
sffamily and others added 24 commits January 14, 2025 08:17
@sffamily
Copy link
Author

Thank you @ntrogh for all the comments, I've updated according to the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants