-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-web.md: Add sentence about Firefox #7892
base: main
Are you sure you want to change the base?
Conversation
@joaomoreno Can you review this docs PR for vscode.dev? |
@@ -179,7 +179,7 @@ Edge and Chrome today support the [File System API](https://developer.mozilla.or | |||
|
|||
### Browser support | |||
|
|||
You can use VS Code for the Web in the latest versions of Chrome, Edge, Firefox, and Safari. Older versions of each browser may not work - we only guarantee support for the latest version. | |||
You can use VS Code for the Web in the latest versions of Chrome, Edge, Firefox, and Safari. Note that on Firefox, if you have enabled the "strict" Enhanced Tracking Protection, you need to to exempt `vscode.dev` for some functionality to work (such as opening a git repo). Older versions of each browser may not work - we only guarantee support for the latest version. | |||
|
|||
> **Tip:** One way to check the compatible browser version is to look at the version of [Playright](https://playwright.dev/) currently used for testing VS Code and review its supported browser versions. You can find the currently used Playwright version in the VS Code repo's [package.json](https://github.com/microsoft/vscode/blob/main/package.json) file at `devDependencies/@playwright/test`. Once you know the Playwright version, for example `1.37`, you can then review the **Browser Versions** section in their [Release notes](https://playwright.dev/docs/release-notes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
,new section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what? if you're a maintainer, feel free to edit the PR as you see fit.
@mb21 Can you show me exactly what happens if you don't exempt vscode.dev? I just tried it on my machine: I set the Protection Settings to Strict, and vscode.dev still works just fine. |
@joaomoreno I believe it only fails if your GitHub account isn't linked to vscode.dev yet. So to test it you'd need to remove the 'app' from your GitHub profile. Then the first time it gives the error:
See e.g. https://www.reddit.com/r/Floorp/comments/1gbymgr/comment/m3rexzg/?context=3 |
No description provided.