Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-web.md: Add sentence about Firefox #7892

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mb21
Copy link

@mb21 mb21 commented Dec 26, 2024

No description provided.

@ntrogh
Copy link
Contributor

ntrogh commented Jan 2, 2025

@joaomoreno Can you review this docs PR for vscode.dev?

@ntrogh ntrogh requested a review from joaomoreno January 2, 2025 10:05
@ntrogh ntrogh added the doc-enhancement suggested addition or improvement label Jan 2, 2025
@@ -179,7 +179,7 @@ Edge and Chrome today support the [File System API](https://developer.mozilla.or

### Browser support

You can use VS Code for the Web in the latest versions of Chrome, Edge, Firefox, and Safari. Older versions of each browser may not work - we only guarantee support for the latest version.
You can use VS Code for the Web in the latest versions of Chrome, Edge, Firefox, and Safari. Note that on Firefox, if you have enabled the "strict" Enhanced Tracking Protection, you need to to exempt `vscode.dev` for some functionality to work (such as opening a git repo). Older versions of each browser may not work - we only guarantee support for the latest version.

> **Tip:** One way to check the compatible browser version is to look at the version of [Playright](https://playwright.dev/) currently used for testing VS Code and review its supported browser versions. You can find the currently used Playwright version in the VS Code repo's [package.json](https://github.com/microsoft/vscode/blob/main/package.json) file at `devDependencies/@playwright/test`. Once you know the Playwright version, for example `1.37`, you can then review the **Browser Versions** section in their [Release notes](https://playwright.dev/docs/release-notes).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,new section

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what? if you're a maintainer, feel free to edit the PR as you see fit.

@joaomoreno
Copy link
Member

@mb21 Can you show me exactly what happens if you don't exempt vscode.dev? I just tried it on my machine: I set the Protection Settings to Strict, and vscode.dev still works just fine.

@mb21
Copy link
Author

mb21 commented Jan 23, 2025

@joaomoreno I believe it only fails if your GitHub account isn't linked to vscode.dev yet. So to test it you'd need to remove the 'app' from your GitHub profile. Then the first time it gives the error:

unable to resolve workspace folder (ENOPRO: No file system provider found for resource 'vscode:vfs://....')

See e.g. https://www.reddit.com/r/Floorp/comments/1gbymgr/comment/m3rexzg/?context=3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-enhancement suggested addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants