Skip to content

API guide: register MCP server #8260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 3, 2025
Merged

API guide: register MCP server #8260

merged 10 commits into from
Jun 3, 2025

Conversation

ntrogh
Copy link
Contributor

@ntrogh ntrogh commented Apr 9, 2025

Fixes #8216

@ntrogh ntrogh requested a review from isidorn April 9, 2025 08:38
@isidorn isidorn requested review from digitarald and connor4312 April 9, 2025 08:39
@isidorn
Copy link
Contributor

isidorn commented Apr 9, 2025

Assigning @digitarald and @connor4312 as reviewers first

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 9, 2025
@connor4312
Copy link
Member

connor4312 commented Apr 9, 2025

I would not merge this until we finalize an API, as it's not very useful for extensions until then and is still subject to change

@ntrogh
Copy link
Contributor Author

ntrogh commented Apr 9, 2025

Thanks. I'll hold off on merging this.

@ntrogh
Copy link
Contributor Author

ntrogh commented May 5, 2025

TODO: incorporate API updates from microsoft/vscode-extension-samples#1182

@connor4312
Copy link
Member

The MCP extension API is now finalized so we should be good to go here :)

Final version: https://github.com/microsoft/vscode/pull/248244/files#diff-0a75aed19c118603eb96332bc0b9c2d7867f4182346d16d18b7fc31b6ceeb321

@isidorn isidorn modified the milestones: April 2025, May 2025 May 8, 2025
Rakalah

This comment was marked as off-topic.

@ntrogh
Copy link
Contributor Author

ntrogh commented May 20, 2025

@connor4312 I've updated the API guide with the latest API changes. Ready for your review.

@ntrogh ntrogh requested a review from connor4312 May 21, 2025 06:32
@ntrogh
Copy link
Contributor Author

ntrogh commented May 21, 2025

@connor4312 Thanks for the pointer to the resolve method. Added description and example. Ready for your review.

isidorn
isidorn previously approved these changes Jun 2, 2025
Copy link
Contributor

@isidorn isidorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Let's wait until Tuesday for @digitarald or @connor4312 to chime in, and if they are busy we can go ahead and merge and than react on their feedback after the initial merge.

connor4312
connor4312 previously approved these changes Jun 2, 2025
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall

@ntrogh ntrogh dismissed stale reviews from connor4312 and isidorn via c0eb42e June 2, 2025 17:32
@ntrogh ntrogh requested a review from isidorn June 3, 2025 08:51
@ntrogh ntrogh merged commit 7ba7eb9 into main Jun 3, 2025
2 checks passed
@ntrogh ntrogh deleted the register-mcp-server-api branch June 3, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MCP server as VS Code extension
6 participants