-
Notifications
You must be signed in to change notification settings - Fork 5.1k
API guide: register MCP server #8260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Assigning @digitarald and @connor4312 as reviewers first |
I would not merge this until we finalize an API, as it's not very useful for extensions until then and is still subject to change |
Thanks. I'll hold off on merging this. |
TODO: incorporate API updates from microsoft/vscode-extension-samples#1182 |
The MCP extension API is now finalized so we should be good to go here :) Final version: https://github.com/microsoft/vscode/pull/248244/files#diff-0a75aed19c118603eb96332bc0b9c2d7867f4182346d16d18b7fc31b6ceeb321 |
@connor4312 I've updated the API guide with the latest API changes. Ready for your review. |
Co-authored-by: Connor Peet <[email protected]>
…t/vscode-docs into register-mcp-server-api
@connor4312 Thanks for the pointer to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Let's wait until Tuesday for @digitarald or @connor4312 to chime in, and if they are busy we can go ahead and merge and than react on their feedback after the initial merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm overall
Fixes #8216