Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipelines and requirements to min python 3.9 #337

Merged
merged 4 commits into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/build-vsix/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ runs:
node-version: ${{ inputs.node_version }}
cache: 'npm'

# Minimum supported version is Python 3.8
- name: Use Python 3.8
# Minimum supported version is Python 3.9
- name: Use Python 3.9
uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.9'

- name: Pip cache
uses: actions/cache@v2
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/pr-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,19 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
python: ['3.8', '3.9', '3.10', '3.11', '3.12-dev']
python: ['3.9', '3.10', '3.11', '3.12', '3.13']

steps:
- name: Checkout
uses: actions/checkout@v3
with:
path: ${{ env.special-working-directory-relative }}

# Install bundled libs using 3.8 even though you test it on other versions.
- name: Use Python 3.8
# Install bundled libs using 3.9 even though you test it on other versions.
- name: Use Python 3.9
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.9'

- name: Update pip, install wheel and nox
run: python -m pip install -U pip wheel nox
Expand All @@ -68,7 +68,7 @@ jobs:
run: python -m nox --session install_bundled_libs
shell: bash

# Now that the bundle is installed to target using python 3.8
# Now that the bundle is installed to target using python 3.9
# switch back the python we want to test with
- name: Use Python ${{ matrix.python }}
uses: actions/setup-python@v5
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/push-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,19 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest]
python: ['3.8', '3.9', '3.10', '3.11', '3.12-dev']
python: ['3.9', '3.10', '3.11', '3.12', '3.13']

steps:
- name: Checkout
uses: actions/checkout@v3
with:
path: ${{ env.special-working-directory-relative }}

# Install bundled libs using 3.8 even though you test it on other versions.
- name: Use Python 3.8
# Install bundled libs using 3.9 even though you test it on other versions.
- name: Use Python 3.9
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.9'

- name: Update pip, install wheel and nox
run: python -m pip install -U pip wheel nox
Expand All @@ -73,7 +73,7 @@ jobs:
run: python -m nox --session install_bundled_libs
shell: bash

# Now that the bundle is installed to target using python 3.8
# Now that the bundle is installed to target using python 3.9
# switch back the python we want to test with
- name: Use Python ${{ matrix.python }}
uses: actions/setup-python@v5
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

A Visual Studio Code extension with support for the Flake8 linter. The extension ships with `flake8==7.1.1`.

> **Note**: The minimum version of Flake8 this extension supports is 5.0.0. If you are having issues with Flake8, please report it to [this issue tracker](https://github.com/PyCQA/flake8/issues) as this extension is just a wrapper around Flake8.
> **Note**: The minimum version of Flake8 this extension supports is 7.0.0. If you are having issues with Flake8, please report it to [this issue tracker](https://github.com/PyCQA/flake8/issues) as this extension is just a wrapper around Flake8.

This extension supports all [actively supported versions](https://devguide.python.org/versions/#status-of-python-versions) of the Python language.

For more information on Flake8, see https://flake8.pycqa.org/

- Minimum supported version of `flake8` is `5.0.0`.
- Minimum supported version of `flake8` is `7.0.0`.

## Usage and Features

Expand Down
2 changes: 1 addition & 1 deletion build/azure-pipeline.pre-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ extends:

- task: UsePythonVersion@0
inputs:
versionSpec: '3.8'
versionSpec: '3.9'
addToPath: true
architecture: 'x64'
displayName: Select Python version
Expand Down
2 changes: 1 addition & 1 deletion build/azure-pipeline.stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ extends:

- task: UsePythonVersion@0
inputs:
versionSpec: '3.8'
versionSpec: '3.9'
addToPath: true
architecture: 'x64'
displayName: Select Python version
Expand Down
4 changes: 2 additions & 2 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,14 @@ def _setup_template_environment(session: nox.Session) -> None:
_install_bundle(session)


@nox.session(python="3.8")
@nox.session(python="3.9")
def install_bundled_libs(session):
"""Installs the libraries that will be bundled with the extension."""
session.install("wheel")
_install_bundle(session)


@nox.session(python="3.8")
@nox.session(python="3.9")
def setup(session: nox.Session) -> None:
"""Sets up the extension for development."""
_setup_template_environment(session)
Expand Down
7 changes: 4 additions & 3 deletions requirements.in
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# This file is used to generate requirements.txt.
# To update requirements.txt, run the following commands.
# Use Python 3.8 when creating the environment or using pip-tools
# 1) pip install pip-tools
# 2) pip-compile --generate-hashes --resolver=backtracking --upgrade ./requirements.in
# Use `uv` with Python 3.9 when creating the environment.
#
# Run following command:
# uv pip compile --generate-hashes --upgrade ./requirements.in > .\requirements.txt

pygls
packaging
Expand Down
8 changes: 2 additions & 6 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
#
# This file is autogenerated by pip-compile with Python 3.8
# by the following command:
#
# pip-compile --generate-hashes ./requirements.in
#
# This file was autogenerated by uv via the following command:
# uv pip compile --generate-hashes ./requirements.in
attrs==25.1.0 \
--hash=sha256:1c97078a80c814273a76b2a298a932eb681c87415c11dee0a6921de7f1b02c3e \
--hash=sha256:c75a69e28a550a7e93789579c22aa26b0f5b83b75dc4e08fe092980051e1090a
Expand Down
2 changes: 1 addition & 1 deletion runtime.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
python-3.8.18
python-3.9.13
7 changes: 4 additions & 3 deletions src/test/python_tests/requirements.in
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# This file is used to generate requirements.txt.
# To update requirements.txt, run the following commands.
# Use Python 3.8 when creating the environment or using pip-tools
# 1) pip install pip-tools
# 2) pip-compile --generate-hashes --resolver=backtracking --upgrade ./src/test/python_tests/requirements.in
# Use `uv` with Python 3.9 when creating the environment.
#
# Run following command:
# uv pip compile --generate-hashes --upgrade ./src/test/python_tests/requirements.in > ./src/test/python_tests/requirements.txt

pytest
PyHamcrest
Expand Down
Binary file modified src/test/python_tests/requirements.txt
Binary file not shown.
Loading