Add auto completion for attribute tags #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzyrobert
force-pushed
the
add_auto_tags
branch
from
8fc7120 to
0df7584
Compare
jzyrobert
force-pushed
the
add_auto_tags
branch
from
0df7584 to
ca85271
Compare
|
Thanks @jzyrobert ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #115
It makes use of the existing
CompletionConfiguration.attributeDefaultValueto decide whether "" or '' should be used.I think the completion function could be made simpler if invalid html can be ignored (e.g.
<a foo==)