Improve shell command formatting

[almarouk]

Consolidates shell command formatting logic into a shared utility function that is used for running in terminal and PET command execution, among other places.
This improves consistency and command path handling.

This should also fix PET command execution on Windows using PowerShell (requires &).

[Copilot]

Pull Request Overview

This PR consolidates shell command formatting logic into a shared utility function to improve consistency across the codebase and fix PowerShell command execution on Windows.

• Introduces centralized command formatting through getShellCommandAsString function
• Fixes PowerShell command execution by properly adding & prefix when needed
• Refactors duplicate shell command formatting logic in terminal and PET execution

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/features/terminal/shells/common/shellUtils.ts	Updates PowerShell command formatting to add & prefix for non-quoted commands
src/features/terminal/runInTerminal.ts	Replaces inline shell formatting logic with centralized utility function
src/features/execution/execUtils.ts	Adds string trimming to quote function for better argument handling
src/extension.ts	Refactors PET command execution to use centralized shell formatting

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[anthonykim1]

Thanks for the PR.
Looks like command will never be undefined here, we could probably remove the | undefined

[almarouk]

undefined is required here since the if ... else tests on selectedOption.label below don't have a default else, therefore the ts compiler will complain with ts(2454).

[anthonykim1]

Now I'm thinking can we just simplify the second else if (...Resolve Environment) into else?
There is only two options that selectionOption.label can take.

[almarouk]

That's true but I didn't want to introduce any unrelated changes with possibly undesirable effects, keeping the PR context relevant and minimal. Should I still change it?

[anthonykim1]

if (command) { could also go away if we remove undefined from type above.

[almarouk]

See reply to previous comment.

[anthonykim1]

I'm not sure if we really need this. Seems like the only places we call this are:

vscode-python-environments/src/features/execution/runAsTask.ts

Lines 29 to 35 in e0eedd3

	let executable = environment.execInfo?.activatedRun?.executable ?? environment.execInfo?.run.executable;
	if (!executable) {
	traceWarn('No Python executable found in environment; falling back to "python".');
	executable = 'python';
	}
	// Check and quote the executable path if necessary
	executable = quoteStringIfNecessary(executable);

and

vscode-python-environments/src/features/execution/runInBackground.ts

Lines 10 to 16 in e0eedd3

	let executable = environment.execInfo?.activatedRun?.executable ?? environment.execInfo?.run.executable;
	if (!executable) {
	traceWarn('No Python executable found in environment; falling back to "python".');
	executable = 'python';
	}
	// Check and quote the executable path if necessary
	executable = quoteStringIfNecessary(executable);

And the executable string that is passed in seems like its path to Python binary.

[almarouk]

Here:

vscode-python-environments/src/extension.ts

Line 492 in e0eedd3

terminal.sendText(`"${petPath}" resolve "${inputPath.trim()}"`, true);

inputPath is user-provided and could have leading white spaces. I did keep the .trim() in this case before eventually processing the string with getShellCommandAsString but I thought also of adding it in the quoting logic for consistency and robustness in future use cases. What do you think?