Improve test #237891
Merged
Improve test #237891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
previously approved these changes
Jan 14, 2025
| }) | ||
| .on('error', reject); | ||
| }); | ||
| await delay(2000); // Wait for the configuration change to propagate. |
There was a problem hiding this comment.
There isn't a better way to wait for this?
There was a problem hiding this comment.
Not sure, trying here: #237904
chrmarti
force-pushed
the
chrmarti/comparable-gecko
branch
from
d4d36ae to
384b832
Compare
chrmarti
force-pushed
the
chrmarti/comparable-gecko
branch
from
384b832 to
7a37c53
Compare
Tyriar
approved these changes
Jan 14, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237890