Repository navigation
Run the marketplace vally skill lint in CI - #201
Merged
Nikola Metulev (nmetulev) merged 2 commits intoSep 30, 2026
Merged
Conversation
Add a vally-lint job that runs @microsoft/vally 0.12.0, the same linter and version github/awesome-copilot applies to external plugins, over the plugin the same way their quality gate does. Replace the hand-written link check from #200 so there is one source of truth, track the pinned dependency with Dependabot, and document the local command. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The lockfile was resolved against an internal npm mirror that is missing five @github/copilot-sdk platform packages, leaving version-less stubs that make npm ci fail with 'Invalid Version'. Rebuild it from the @microsoft/vally 0.12.0 dependency closure in github/awesome-copilot's lockfile so CI resolves from registry.npmjs.org and matches the gate's transitive versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run the same skill linter marketplaces use, so marketplace failures show up in our CI before submission. The awesome-copilot listing updates failed on vally
valid-refs, which rejects markdown links outside a skill's own folder, after the release had already shipped.vally-lintjob runs@microsoft/vally0.12.0, the version github/awesome-copilot pins in its lockfile, viascripts/vally/lint-skills.mjs. The harness mirrors awesome-copilot'seng/external-plugin-quality-gates.mjs: it lints theskillspaths declared inplugin.json, or the plugin root when none are declared, as in our case.scripts/vally; CONTRIBUTING documents the local command (npm ci --prefix scripts/vally; node scripts/vally/lint-skills.mjs), and RELEASING addsvally-lintto the required checks.Verified locally: on the pre-fix commit
c1b6053, the job fails the same 7 skills that awesome-copilot's gate failed (exit 1). On currentstaging, all 8 skills pass (exit 0). The remaining plugin validator still passes.Maintainers: add
vally-lintto the required status checks in branch protection.Type of Change
Checklist