Repository navigation
fix: return exit code 1 on parse errors #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Akhil Gupta (akhil9tiet)
wants to merge
26
commits into
microsoft:main
Choose a base branch
from
akhil9tiet:fix/1015-parse-error-exit-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d43f830
fix: return exit code 1 on parse errors
akhil9tiet 9bdba15
Delete src/winapp-CLI/WinApp.Cli/Program.cs
akhil9tiet f76e481
fix: return exit code 1 on parse errors
akhil9tiet 5c28e9e
Merge branch 'main' into fix/1015-parse-error-exit-code
zateutsch d3b7f1c
fix: make parse-error callback async (compilation fix)
akhil9tiet 994ad2d
Delete src/winapp-CLI/WinApp.Cli/Program.cs
akhil9tiet 21a4170
Rename winapp-Program-fix.cs to Program.cs
akhil9tiet 772a4bb
test: regression for parse-error exit code 1
akhil9tiet 30ef112
Delete src/winapp-CLI/WinApp.Cli.Tests/ProgramTests.cs
akhil9tiet e88cba2
Rename winapp-ProgramTests.cs to ProgramTests.cs
akhil9tiet 8cb5472
Upload winapp-Program-rebased.cs (intermediate step)
akhil9tiet 383952b
Delete src/winapp-CLI/WinApp.Cli/Program.cs
akhil9tiet b884eeb
fix: rebase exit-code fix onto current main (resolve conflict)
akhil9tiet 915f370
Upload winapp-Program-proper.cs (intermediate step)
akhil9tiet 6856c28
Delete src/winapp-CLI/WinApp.Cli/Program.cs
akhil9tiet d6fb795
fix: rebase exit-code fix onto current main with help-pointer flow
akhil9tiet 63d5a4f
Merge branch 'main' into fix/1015-parse-error-exit-code
akhil9tiet e376c97
Merge branch 'main' into fix/1015-parse-error-exit-code
zateutsch 2bb0e69
Merge branch 'main' into fix/1015-parse-error-exit-code
nmetulev 79018fd
fix: add missing await in async lambda
akhil9tiet 69043b7
fix: add missing await in async lambda
akhil9tiet 49b3e1e
fix: add missing await in async lambda
akhil9tiet 612074b
Merge branch 'main' into fix/1015-parse-error-exit-code
nmetulev c32e12c
fix: await InvokeWithHelpPointerAsync to fix CS4016
akhil9tiet 378e707
Merge branch 'main' into fix/1015-parse-error-exit-code
nmetulev 1415191
Merge branch 'main' into fix/1015-parse-error-exit-code
zateutsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.