Repository navigation
Add a contributor PR lifecycle skill - #896
Conversation
Guide preparation, evidence-based presentation, and current-head readiness without merging. Keep authorized review fixes in the existing PR. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
State: agent-preparing |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation is internally consistent, links and formatting validate, and no unresolved defects were identified.
Review effort: Balanced
Findings: None
What changed in this PR
Adds a contributor-only workflow for preparing, presenting, and finishing PRs without conflating technical readiness with approval.
Changes:
- Adds the
pr-lifecycleskill and readiness states. - Keeps authorized fixes in the existing PR.
- Connects existing review guidance to the lifecycle workflow.
| File | Description |
|---|---|
.github/skills/README.md |
Documents the lifecycle skill. |
.github/skills/pr-review/SKILL.md |
Directs authorized fixes and readiness tracking to the lifecycle workflow. |
.github/skills/pr-lifecycle/SKILL.md |
Defines preparation, presentation, validation, and readiness procedures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Build Metrics ReportValidation passed. All required build and validation jobs succeeded. Binary Sizes
.NET Test Results (TRX reports)Other suites are reflected in the overall validation status above. ✅ 7598 passed, 37 skipped out of 7635 tests in 1368.7s (+1.6s vs. baseline) Test Coverage✅ 85.7% line coverage, 79.9% branch coverage · ✅ no change vs. baseline CLI Startup Time81ms median (x64, Try This BuildInstalls the MSIX for your architecture, replacing any previously installed build. Needs the GitHub CLI — the command offers to install it and sign you in if it is missing. & ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) 896Switching between builds often?Put the tool on your PATH once: & ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) -AddToPathThen this build is just: winapp-pr 896Run Updated 2026-09-21 18:30:49 UTC · commit |
Description
Contributors need a consistent way to take a PR from preparation to an honest, current-head readiness assessment without confusing that with approval or permission to merge.
Adds a contributor-only Prepare → Present → Finish skill. It keeps authorized fixes in the existing PR, asks for concrete evidence, and maintains one status comment separately from the feature description. Draft-only and review-only requests remain read-only. No shipped CLI/plugin behavior changes.
Usage Example
Illustrative contributor request:
Get this PR ready for review.Before: the existing review skill instructed agents to open a separate PR for fixes, and there was no contributor lifecycle skill defining readiness.
After: the agent keeps fixes in the existing PR and uses one of three mutually exclusive states:
agent-preparingagent-blockedagent-ready-for-reviewA substantive changes request blocks readiness; human approval still pending without substantive reservations can coexist with technical readiness. The skill never merges or enables auto-merge.
Related Issue
N/A.
Type of Change
Checklist
git diff --checkpassed.scripts\validate-plugin-package.ps1passed; shipped plugin contents are unchanged.Screenshots / Demo
Not applicable: contributor Markdown only. The request/state example above illustrates the workflow, not a completed live readiness run.
Additional Notes
No new service, workflow or configuration schema. No NativeAOT build was run locally for this documentation-only change. Live CI/review state is tracked in a separate lifecycle comment; this PR is not being merged.