Skip to content

Add a contributor PR lifecycle skill - #896

Merged
Nikola Metulev (nmetulev) merged 1 commit into
mainfrom
nmetulev-pr-lifecycle-skill
Sep 21, 2026
Merged

Nikola Metulev (nmetulev) merged 1 commit into
mainfrom
nmetulev-pr-lifecycle-skill

Conversation

@nmetulev

Copy link
Copy Markdown
Member

Description

Contributors need a consistent way to take a PR from preparation to an honest, current-head readiness assessment without confusing that with approval or permission to merge.

Adds a contributor-only Prepare → Present → Finish skill. It keeps authorized fixes in the existing PR, asks for concrete evidence, and maintains one status comment separately from the feature description. Draft-only and review-only requests remain read-only. No shipped CLI/plugin behavior changes.

Usage Example

Illustrative contributor request: Get this PR ready for review.

Before: the existing review skill instructed agents to open a separate PR for fixes, and there was no contributor lifecycle skill defining readiness.

After: the agent keeps fixes in the existing PR and uses one of three mutually exclusive states:

State Meaning
agent-preparing Fixing findings or ordinarily waiting for CI/review
agent-blocked External intervention needed, with blocker, owner and next step
agent-ready-for-review Technical gates verified for the current head/base; not human approval or merge permission

A substantive changes request blocks readiness; human approval still pending without substantive reservations can coexist with technical readiness. The skill never merges or enables auto-merge.

Related Issue

N/A.

Type of Change

  • 📝 Documentation

Checklist

  • Tested locally on Windows: frontmatter/name checks, Markdown parsing, balanced fences, relative links and git diff --check passed.
  • scripts\validate-plugin-package.ps1 passed; shipped plugin contents are unchanged.

Screenshots / Demo

Not applicable: contributor Markdown only. The request/state example above illustrates the workflow, not a completed live readiness run.

Additional Notes

No new service, workflow or configuration schema. No NativeAOT build was run locally for this documentation-only change. Live CI/review state is tracked in a separate lifecycle comment; this PR is not being merged.

Guide preparation, evidence-based presentation, and current-head readiness without merging. Keep authorized review fixes in the existing PR.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 21, 2026 17:44
@nmetulev Nikola Metulev (nmetulev) added the agent-preparing Agent is addressing feedback or completing required validation and CI label Sep 21, 2026
@nmetulev

Copy link
Copy Markdown
Member Author

State: agent-preparing
Assessed: head d08e21018bbd1def8867d9fc67d7b1860aba08a9 against main@ecb45751e984f29fc81ecc43a4452bd8dbe994b9.
Evidence: Contributor Markdown frontmatter/name, fences, relative links, Markdown parsing and whitespace checks passed on Windows. scripts\validate-plugin-package.ps1 passed. No local NativeAOT build for this docs-only change. Build and Package is running.
Review: Local instruction/contradiction inspection completed; independent current-head review is pending. No review bodies or inline threads existed at assessment. Required human approval is pending; no approval or merge readiness is claimed.
Pending: Independent current-head review and any actionable findings; required build-and-package completion; final live discussion/head/base/conflict recheck.
Blocker / owner / next step: No external intervention currently identified; ordinary CI/review wait.
Resume: Not actively monitoring. Resume when CI/review results arrive and re-read the live PR before changing state.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The documentation is internally consistent, links and formatting validate, and no unresolved defects were identified.

Review effort: Balanced
Findings: None

What changed in this PR

Adds a contributor-only workflow for preparing, presenting, and finishing PRs without conflating technical readiness with approval.

Changes:

  • Adds the pr-lifecycle skill and readiness states.
  • Keeps authorized fixes in the existing PR.
  • Connects existing review guidance to the lifecycle workflow.
File Description
.github/​skills/​README.md Documents the lifecycle skill.
.github/​skills/​pr-review/​SKILL.md Directs authorized fixes and readiness tracking to the lifecycle workflow.
.github/​skills/​pr-lifecycle/​SKILL.md Defines preparation, presentation, validation, and readiness procedures.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Build Metrics Report

Validation passed. All required build and validation jobs succeeded.

Binary Sizes

Artifact Baseline Current Delta
CLI (ARM64) 57.03 MB 57.03 MB ✅ 0.0 KB (0.00%)
CLI (x64) 57.07 MB 57.07 MB ✅ 0.0 KB (0.00%)
MSIX (ARM64) 23.72 MB 23.72 MB 📉 -0.4 KB (-0.00%)
MSIX (x64) 25.16 MB 25.16 MB 📈 +0.2 KB (+0.00%)
NPM Package 49.44 MB 49.44 MB 📉 -0.2 KB (-0.00%)
NuGet Package 49.55 MB 49.55 MB 📉 -0.1 KB (-0.00%)

.NET Test Results (TRX reports)

Other suites are reflected in the overall validation status above.

✅ 7598 passed, 37 skipped out of 7635 tests in 1368.7s (+1.6s vs. baseline)

Test Coverage

✅ 85.7% line coverage, 79.9% branch coverage · ✅ no change vs. baseline

CLI Startup Time

81ms median (x64, winapp --version) · ⚠️ +16ms vs. baseline

Try This Build

Installs the MSIX for your architecture, replacing any previously installed build. Needs the GitHub CLI — the command offers to install it and sign you in if it is missing.

& ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) 896
Switching between builds often?

Put the tool on your PATH once:

& ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) -AddToPath

Then this build is just:

winapp-pr 896

Run winapp-pr with no arguments to pick from a list of open PRs.


Updated 2026-09-21 18:30:49 UTC · commit d08e210 · workflow run

@nmetulev
Nikola Metulev (nmetulev) merged commit 4567e42 into main Sep 21, 2026
34 checks passed
@nmetulev
Nikola Metulev (nmetulev) deleted the nmetulev-pr-lifecycle-skill branch September 21, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-preparing Agent is addressing feedback or completing required validation and CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants