Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bicep support #272

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add Bicep support #272

wants to merge 9 commits into from

Conversation

Gijsreyn
Copy link

@Gijsreyn Gijsreyn commented Jan 2, 2025

This PR adds Bicep support to deploy a new WinGet Rest Source in Azure.

@Gijsreyn
Copy link
Author

Gijsreyn commented Jan 2, 2025

Hi @denelon. I already created an initial draft to add Bicep support. Even thought the New-WinGetSource is a one-liner, I think users would love to see Bicep support as well. With the Graph API also supported in Bicep, we should be able to add the support for Entra ID Service Principal.

I was curious to your thoughts, that's why I already opened it as draft.

@Gijsreyn Gijsreyn marked this pull request as ready for review January 3, 2025 13:09
@Gijsreyn Gijsreyn requested a review from a team as a code owner January 3, 2025 13:09
@Gijsreyn
Copy link
Author

Gijsreyn commented Jan 3, 2025

@denelon, I've submitted this for review since the PR has grown quite large. I've tried converting the basic ARM templates to Bicep. There were a few challenges, but that's to be expected.

I've done some initial local testing. Before diving into extensive testing (initial setup checks for linting only), I want to see if we can proceed with this. Some documentation has been added, though it might not be in the correct location.

On the other side, after working on this for a while, I realize it might not belong in this repository. Maybe we can ask the AVM team to create a pattern for all three implementation performances. Let me know your thoughts.

@denelon
Copy link
Contributor

denelon commented Jan 3, 2025

Eventually, I'd like to have this work lead into an Azure Marketplace offering. I'd want to keep that code here in this repository with some kind of "small", "medium", "large" concept to support different scale out scenarios.

@Gijsreyn
Copy link
Author

Gijsreyn commented Jan 4, 2025

Cool, thanks for the reply Demitrius. I'll leave it up to the team to review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants