Skip to content

[Do not review] Adding set up scripts#271

Closed
AmelBawa-msft wants to merge 22 commits intomainfrom
user/amelbawa/dev-setup
Closed

[Do not review] Adding set up scripts#271
AmelBawa-msft wants to merge 22 commits intomainfrom
user/amelbawa/dev-setup

Conversation

@AmelBawa-msft
Copy link
Copy Markdown
Contributor

@AmelBawa-msft AmelBawa-msft commented May 5, 2026

📖 Description

Author: @crutkas

Script review:

⚠️ I had to run before using winget configure

winget install Microsoft.VCRedist.2015+.x64

scripts/windows/

  • _common/
  • dotnet/
    • ✅ Validated on a VM
  • go/
    • ✅ Validated on a VM
  • java/
    • ✅ Validated on a VM
  • php/
    • ✅ Validated on a VM
  • python/
    • ✅ Validated on a VM
  • rust/
    • ✅ Validated on a VM
  • typescript/
    • ✅ Validated on a VM
  • winforms/
    • ✅ Validated on a VM
  • winui/

🔗 References

🔍 Validation

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AmelBawa-msft
Copy link
Copy Markdown
Contributor Author

@copilot address #271 (comment)

Copy link
Copy Markdown

Copilot AI commented May 5, 2026

@copilot address #271 (comment)

Addressed in commit 368ae03. Added all 31 unrecognized words to the appropriate spelling expect files (software.txt, windows_terms.txt, generic_terms.txt) and added the suggested bash set-argument pattern to patterns.txt.

@AmelBawa-msft
Copy link
Copy Markdown
Contributor Author

@copilot revert your change in patterns.txt‎

Copy link
Copy Markdown

Copilot AI commented May 5, 2026

@copilot revert your change in patterns.txt‎

Done in commit 3263b81. The bash set-argument pattern has been removed from patterns.txt.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (13)
diffs
JEP
Lifecycle
Linux
Mrt
mvn
norestart
pri
println
TFM
typeof
vswhere
wdss
These words are not needed and should be removed debian euo gradlew Jdk linux pipefail sideloaded sudoer tarball uvx vendored versioned winbuild wincreate

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the [email protected]:microsoft/winget-dsc.git repository
on the user/amelbawa/dev-setup branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.26/apply.pl' |
perl - 'https://github.com/microsoft/winget-dsc/actions/runs/25470855477/attempts/1' &&
git commit -m 'Update check-spelling metadata'
Warnings ⚠️ (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

⚠️ Warnings Count
⚠️ ignored-expect-variant 2

See ⚠️ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants