Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: advaith.CurrencyConverter version 1.2.0 #171128

Closed
wants to merge 2 commits into from
Closed

New package: advaith.CurrencyConverter version 1.2.0 #171128

wants to merge 2 commits into from

Conversation

Advaith3600
Copy link
Contributor

@Advaith3600 Advaith3600 commented Sep 2, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-No-Executables labels Sep 2, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Sep 3, 2024

Hi @Advaith3600,

This package's files look like a PowerToys plugin. Is Microsoft.PowerToys a dependency?

Edit: Forgot to paste the screenshot.
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Sep 3, 2024
@Advaith3600
Copy link
Contributor Author

Yes, it is a PowerToys Run plugin

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 3, 2024
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a PowerToys Run plugin

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. Changes-Requested Changes Requested labels Sep 3, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-No-Executables New-Package labels Sep 3, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Sep 3, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Sep 10, 2024

Automatic Validation ended with:

{
"$id": "1",
"innerException": null,
"message": "Artifact InstallationVerificationLogs was not found for build 613210.",
"typeName": "Microsoft.TeamFoundation.Build.WebApi.ArtifactNotFoundException, Microsoft.TeamFoundation.Build2.WebApi",
"typeKey": "ArtifactNotFoundException",
"errorCode": 0,
"eventId": 3000
}

@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 10, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Sep 10, 2024
Copy link
Contributor

Hello Advaith3600,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 10, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Package Cache{c1be0fe8-b34c-4f60-a9a1-939bf696151c}\PowerToysUserSetup-0.84.0-x64.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\Package Cache\F7119E3AB3D5CB3ADCD9A57F0EC227F783695819\MicrosoftEdgeWebview2Setup.exe returned exit code: -1
Executable C:\Program Files (x86)\Microsoft\EdgeUpdate\1.3.155.77\MicrosoftEdgeUpdate.exe returned exit code: -1606220282
Executable C:\Program Files (x86)\Microsoft\EdgeUpdate\1.3.155.77\MicrosoftEdgeUpdateCore.exe returned exit code: -2147024894
Executable C:\Program Files (x86)\Microsoft\EdgeUpdate\MicrosoftEdgeUpdate.exe returned exit code: -1606220282
Executable C:\Program Files (x86)\Microsoft\EdgeUpdate\Download{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}\128.0.2739.67\MicrosoftEdge_X64_128.0.2739.67.exe returned exit code: 3
Executable C:\Program Files (x86)\Microsoft\EdgeCore\128.0.2739.67\BHO\ie_to_edge_stub.exe returned exit code: 1
Executable C:\Program Files (x86)\Microsoft\EdgeCore\128.0.2739.67\cookie_exporter.exe returned exit code: -1610612722
Executable C:\Program Files (x86)\Microsoft\EdgeCore\128.0.2739.67\elevation_service.exe returned exit code: 1063
Executable C:\Program Files (x86)\Microsoft\EdgeCore\128.0.2739.67\msedgewebview2.exe returned exit code: 13
Executable C:\Program Files (x86)\Microsoft\EdgeCore\128.0.2739.67\msedge_pwa_launcher.exe returned exit code: -2147483645
Executable C:\Program Files (x86)\Microsoft\EdgeCore\128.0.2739.67\pwahelper.exe returned exit code: 1
Executable C:\Program Files (x86)\Microsoft\EdgeCore\128.0.2739.67\Installer\setup.exe returned exit code: 3
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\cookie_exporter.exe returned exit code: -1610612722
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\elevation_service.exe returned exit code: 1063
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\msedge.exe returned exit code: 13
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\msedgewebview2.exe returned exit code: 13
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\msedge_pwa_launcher.exe returned exit code: -2147483645
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\pwahelper.exe returned exit code: 1
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\Installer\setup.exe returned exit code: 501
Executable C:\Program Files (x86)\Microsoft\EdgeWebView\Application\128.0.2739.67\BHO\ie_to_edge_stub.exe returned exit code: 1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.ActionRunner.exe returned exit code: 1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.Awake.exe returned exit code: -532462766
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.ColorPickerUI.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.CropAndLock.exe returned exit code: 1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.FancyZonesEditor.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.GcodePreviewHandler.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.GcodeThumbnailProvider.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.ImageResizer.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.MarkdownPreviewHandler.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.MonacoPreviewHandler.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.MouseJumpUI.exe returned exit code: -532462766
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.MouseWithoutBorders.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.MouseWithoutBordersHelper.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.PdfPreviewHandler.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.PdfThumbnailProvider.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.PowerAccent.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.QoiPreviewHandler.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.QoiThumbnailProvider.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.ShortcutGuide.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.StlThumbnailProvider.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.SvgPreviewHandler.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.SvgThumbnailProvider.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.Update.exe returned exit code: 1
Checking if C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesEditor.exe executable file can be started.
Launching executable file: C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesEditor.exe
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesEditor.exe ran for less than 10 seconds: False
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesEditor.exe returned exit code: -1
Checking if C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncher.exe executable file can be started.
Launching executable file: C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncher.exe
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncher.exe ran for less than 10 seconds: True
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncher.exe returned exit code: 1
Checking if C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncherUI.exe executable file can be started.
Launching executable file: C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncherUI.exe
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncherUI.exe ran for less than 10 seconds: False
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesLauncherUI.exe returned exit code: -1
Checking if C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesSnapshotTool.exe executable file can be started.
Launching executable file: C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesSnapshotTool.exe
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.WorkspacesSnapshotTool.exe ran for less than 10 seconds: True
Executable C:\Users\validator\AppData\Local\PowerToys\Tools\PowerToys.BugReportTool.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\KeyboardManagerEditor\PowerToys.KeyboardManagerEditor.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\KeyboardManagerEngine\PowerToys.KeyboardManagerEngine.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\Tools\PowerToys.StylesReportTool.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.EnvironmentVariables.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.FileLocksmithUI.exe returned exit code: -1073741189
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.Hosts.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.MeasureToolUI.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.Peek.UI.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.PowerRename.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.RegistryPreview.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\RestartAgent.exe returned exit code: -1073740791
Executable C:\Program Files (x86)\Microsoft\EdgeUpdate\Download{F3017226-FE2A-4295-8BDF-00C3A9A7E4C5}\128.0.2739.67\MicrosoftEdge_X64_128.0.2739.67.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\PowerToys.FileLocksmithUI.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\PowerToys.MouseJumpUI.exe returned exit code: -1
Executable C:\Users\validator\AppData\Local\PowerToys\WinUI3Apps\RestartAgent.exe returned exit code: -1

Automated error analysis suggests -1073740791 may mean Stack overflow / exhaustion.

Automated error analysis suggests -532462766 may mean EXCEPTION_COMPLUS (Unhandled Exception)

Automated error analysis suggests 1606 may mean ERROR_UNKNOWN_FEATURE - Feature ID not registered.

Automated error analysis suggests 1610 may mean ERROR_BAD_CONFIGURATION - The configuration data for this product is corrupt.

(Automated response - build 895.)

@stephengillie stephengillie removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Validation-Retry labels Sep 10, 2024
@stephengillie
Copy link
Collaborator

I didn't see [this package] listed in the settings, nor did the shortcuts work.

This is unchanged.

@Advaith3600
Copy link
Contributor Author

I had to visit the package page to find how to use this. I didn't see it listed in the settings, nor did the shortcuts work.

The plugin requires Microsoft PowerToys to be installed on the machine. Once it's installed the exe file can be ran to install it. The user will have to close PowerToys and open it again to see it working.

About the logs you are posting, is it an issue with the exe or the config? Is this something I have to fix? If yes, could you guide me towards some direction?

@stephengillie
Copy link
Collaborator

stephengillie commented Sep 11, 2024

Hi @Advaith3600,

The plugin requires Microsoft PowerToys to be installed on the machine.

Yes, PowerToys is installed. It's inside PowerToys Run settings that I don't see settings for this plugin.

Once it's installed the exe file can be ran to install it.

Yes, this is the order in which the dependency system installs packages.

The user will have to close PowerToys and open it again to see it working.

Does PowerToys need to be running during this plugin's installation? Because the package manager doesn't currently do this, and might not have the functionality at this time.

About the logs you are posting, is it an issue with the exe or the config? Is this something I have to fix? If yes, could you guide me towards some direction?

These logs are the ADO pipeline logs, extracted from the run artifacts, and filtered to include and exclude specific terms. Then strings from the logs are matched against a list of numerical strings, and the corresponding message is appended as the automated error analysis.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Sep 16, 2024
Copy link
Contributor

Hello @Advaith3600,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

@ItzLevvie
Copy link
Contributor

Close with reason: Stale pull request;

@microsoft-github-policy-service microsoft-github-policy-service bot removed the No-Recent-Activity No activity has occurred on this work item for seven days. label Sep 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Sep 16, 2024
@Advaith3600
Copy link
Contributor Author

Hello, sorry for the late reply, I was quite busy the past couple of weeks

Does PowerToys need to be running during this plugin's installation? Because the package manager doesn't currently do this, and might not have the functionality at this time.

The exe can be run while PowerToys is running or not. It won't affect the installation. However, if PowerToys is already running, restarting it is necessary for the plugin to show up in the listing.

I found another plugin for PowerToys which has already been added to Winget. Could you please let me know if there is something I have to do from my side?

@Advaith3600 Advaith3600 deleted the advaith.CurrencyConverter-1.2.0-b9363701-39ec-486b-b9aa-aa691f425785 branch September 20, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: PowerToys-Run-Currency-Converter
4 participants