Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submitting Quanshi Meeting version 6.26.24121301 #210750

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Submitting Quanshi Meeting version 6.26.24121301 #210750

merged 2 commits into from
Jan 15, 2025
+95 −0

Conversation

quanshi-123
Copy link
Contributor

@quanshi-123 quanshi-123 commented Jan 13, 2025 •
edited
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@quanshi-123
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Jan 13, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 13, 2025
stephengillie
stephengillie requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1/13/2025 1:11:44 AM
Installer Verification Analysis Context Information:
Specified hash doesn't match.
Actual hash: 23694E63B699AC8A9C17350AC41351AD0EF789B8025D5B2EA2C73EC400C7BB30
Expected hash: 8f15912cadd197c6221b363820c3a29a30e0f65fce5b4d564fa5ad4ba0c58f58

manifests/q/Quanshi/QuanshiMeeting/6.26.24121301/Quanshi.QuanshiMeeting.installer.yaml Outdated Show resolved Hide resolved
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Jan 14, 2025
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

Found duplicate pull request(s)

@wingetbot wingetbot added New-Package Possible-Duplicate Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 14, 2025
@wingetbot wingetbot mentioned this pull request Jan 14, 2025
Closed
7 tasks
@stephengillie stephengillie mentioned this pull request Jan 14, 2025
Closed
7 tasks
@stephengillie
Copy link
Collaborator

Verify:
image
image
image
image

Hi @quanshi-123,

Should this package havethe PackageIdentifier of G-Net.MeetNow instead? The only place where Quanshi is mentioned is the website name.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 14, 2025
@quanshi-123
Copy link
Contributor Author

Thank you for your reply. The English name of QuanshiMeeting software is G-Net MeetNow, and its publisher is Quanshi QuanshiMeeting

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 15, 2025
@stephengillie stephengillie removed Possible-Duplicate Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 15, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d48a857 into microsoft:master Jan 15, 2025
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 15, 2025
@quanshi-123
Copy link
Contributor Author

Thank you for your prompt handling.
I have a question, why can't I search for QuanshiMeeting by entering 'winget search QuanMeeting' ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quanshi-123 @wingetbot @stephengillie