Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: DuckStudio.GitHubView.Nightly version 2025.01.19.12849721517 #213844

Merged
merged 3 commits into from
Jan 23, 2025
Merged

New version: DuckStudio.GitHubView.Nightly version 2025.01.19.12849721517 #213844

merged 3 commits into from
Jan 23, 2025

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Jan 20, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 20, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 20, 2025
DuckDuckStudio
DuckDuckStudio suggested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@DuckDuckStudio DuckDuckStudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another encoding issue???

...io/GitHubView/Nightly/2025.01.19.12849721517/DuckStudio.GitHubView.Nightly.locale.en-US.yaml Outdated Show resolved Hide resolved
...io/GitHubView/Nightly/2025.01.19.12849721517/DuckStudio.GitHubView.Nightly.locale.zh-CN.yaml Outdated Show resolved Hide resolved
@Exorcism0666 @DuckDuckStudio
Apply suggestions from code review
88df4eb 
Co-authored-by: 鸭鸭「カモ」 <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Installation-Error Error installing application Changes-Requested Changes Requested labels Jan 20, 2025
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jan 20, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 20, 2025
DuckDuckStudio
DuckDuckStudio approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@DuckDuckStudio DuckDuckStudio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, the manifest LGTM.
For the Validation-Installation-Error Error installing application label, I'm not sure what's going on, I kept encountering this label in my last PR (#212507) as well, but it passed pipeline validation at the end.

Edit:
If this error exists only on devices with non-x64 architectures, please remove the installer for the corresponding architecture. I've recently been updating the build workflow for this package.

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335187
2025-01-20 09:35:45.646 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerSharedLib\SHA256.cpp(144)\WindowsPackageManager.dll!00007FFCCDD5273F: (caller: 00007FFCCDD9AEC4) Exception(2) tid(1cec) 8A150040
2025-01-20 09:35:47.455 [FAIL] Installer failed security check. Url: https://github.com/DuckDuckStudio/GitHubView/releases/download/2025.01.19.12849721517/GitHubView-2025.01.19.12849721517-Setup-windows.exe Result: 0x80004005
MSI (s) (BC:AC) [09:35:27:475]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (BC:AC) [09:35:27:475]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (BC:AC) [09:35:27:475]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (BC:AC) [09:35:27:475]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (BC:AC) [09:35:27:475]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
MSI (s) (BC:AC) [09:35:28:426]: Executing op: ComponentRegister(ComponentId={4C4F177D-EAA8-526E-B5BA-A435AB8AE909},KeyPath=2285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.12\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=1)
MSI (s) (BC:AC) [09:35:29:637]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=1,,)
Property(S): ErrorDialog = ErrorDlg
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (BC:C4) [09:35:34:077]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (BC:C4) [09:35:34:077]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (BC:C4) [09:35:34:077]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (BC:C4) [09:35:34:077]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (BC:C4) [09:35:34:077]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
MSI (s) (BC:EC) [09:35:38:624]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (BC:EC) [09:35:38:624]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (BC:EC) [09:35:38:624]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (BC:EC) [09:35:38:624]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (BC:EC) [09:35:38:624]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
2025-01-20 09:27:37.784 [FAIL] Installer failed security check. Url: https://github.com/DuckDuckStudio/GitHubView/releases/download/2025.01.19.12849721517/GitHubView-2025.01.19.12849721517-Setup-windows.exe Result: 0x80004005
MSI (s) (40:74) [09:27:27:286]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (40:74) [09:27:27:286]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (40:74) [09:27:27:286]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (40:74) [09:27:27:286]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (40:74) [09:27:27:286]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
MSI (s) (40:74) [09:27:28:489]: Executing op: ComponentRegister(ComponentId={BE010199-713F-57C2-9E29-CAA2CA6BC85C},KeyPath=0285\SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules\C:\Program Files\dotnet\shared\Microsoft.NETCore.App\8.0.12\mscordaccore.dll,State=3,,Disk=1,SharedDllRefCount=0,BinaryType=0)
MSI (s) (40:74) [09:27:30:036]: Executing op: RegOpenKey(Root=-2147483646,Key=SOFTWARE\Microsoft\Windows\Windows Error Reporting\RuntimeExceptionHelperModules,,BinaryType=0,,)
MSI (s) (40:EC) [09:27:30:473]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (40:EC) [09:27:30:473]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (40:EC) [09:27:30:473]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (40:EC) [09:27:30:473]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (40:EC) [09:27:30:473]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
MSI (s) (40:28) [09:27:31:067]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (40:28) [09:27:31:067]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (40:28) [09:27:31:067]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (40:28) [09:27:31:067]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (40:28) [09:27:31:067]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.

Automated error analysis suggests 80004005 may mean Resource missing

(Automated response - build 945.)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Defender-Error labels Jan 21, 2025
@DuckDuckStudio
Copy link
Contributor

DuckDuckStudio commented Jan 22, 2025 •
edited
Loading

Is that the issue again?

I don't understand how this was detected, all processing in my application is local except for sending GET requests to the GitHub API, and no changes were made to any other files (之后可能会对程序自身的config.json进行修改，但除此之外就没有别的了...)。
And it build in GitHub Action...

Edit:
image
image

@Exorcism0666
Copy link
Contributor Author

Is that the issue again?

I don't understand how this was detected, all processing in my application is local except for sending GET requests to the GitHub API, and no changes were made to any other files (may follow up with changes to the program's own config file config.json, but other than that there's nothing else...)。 And it build in GitHub Action...

Edit: image image

CC @stephengillie

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jan 22, 2025
@DuckDuckStudio
Copy link
Contributor

DuckDuckStudio
DuckDuckStudio reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@DuckDuckStudio DuckDuckStudio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉，看了新的PR后才发现这个问题
不过这是个 Nightly 版本，发行说明加不加无所谓。

...io/GitHubView/Nightly/2025.01.19.12849721517/DuckStudio.GitHubView.Nightly.locale.zh-CN.yaml Show resolved Hide resolved
...io/GitHubView/Nightly/2025.01.19.12849721517/DuckStudio.GitHubView.Nightly.locale.en-US.yaml Show resolved Hide resolved
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Defender-Error Validation-Installation-Error Error installing application labels Jan 22, 2025
@Exorcism0666 @DuckDuckStudio
Apply suggestions from code review
7f90f18 
Co-authored-by: 鸭鸭「カモ」 <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@stephengillie
Copy link
Collaborator

Is that the issue again?

I don't understand how this was detected, all processing in my application is local except for sending GET requests to the GitHub API, and no changes were made to any other files (may follow up with changes to the program's own config file config.json, but other than that there's nothing else...)。 And it build in GitHub Action...
Edit:

CC @stephengillie

Unfortunately, this hasn't progressed far enough in the pipeline for me to manually complete.

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 23, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 5c220f6 into microsoft:master Jan 23, 2025
2 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 23, 2025
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckDuckStudio DuckDuckStudio DuckDuckStudio approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: DuckStudio.GitHubView.Nightly version 2025.01.19.12849721517
4 participants
@Exorcism0666 @wingetbot @stephengillie @DuckDuckStudio