Skip to content

Feature 21884 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 14, 2025
Merged

Feature 21884 #484

merged 22 commits into from
Oct 14, 2025

Conversation

@ashwinikarke
Copy link

@ashwinikarke ashwinikarke commented Sep 24, 2025

For workload identity policies, I couldn’t test with actual data due to license limitations, so I validated them using test data.

Screenshot 2025-09-22 160218 Screenshot 2025-09-22 160644

@ashwinikarke
Copy link
Author

ashwinikarke commented Sep 24, 2025

@microsoft-github-policy-service agree company="Perennial Sys"

merill
merill requested changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@merill merill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use the database to query for apps, service principals.

Even if there is no license,the expected experience is to list all the apps that need the CA policy applied.

@ashwinikarke
Copy link
Author

ashwinikarke commented Sep 26, 2025

We need to use the database to query for apps, service principals.

Even if there is no license,the expected experience is to list all the apps that need the CA policy applied.

@merill Updated code with recent updates.
image

@ashwinikarke ashwinikarke requested a review from merill September 26, 2025 07:10
merill
merill requested changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@merill merill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see review comments.

@merill merill added the changes requested Reviewer has requested changes. Once changes are completed, please set to `ready for review` label Sep 29, 2025
@ashwinikarke ashwinikarke requested a review from merill September 29, 2025 14:44
merill
merill approved these changes Oct 14, 2025
View reviewed changes
Copy link
Collaborator

@merill merill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@merill merill merged commit d5b7d72 into microsoft:psnext Oct 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merill merill merill approved these changes

Assignees

@ashwinikarke ashwinikarke

Labels

changes requested Reviewer has requested changes. Once changes are completed, please set to `ready for review`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ashwinikarke @merill @komalp2025 @KManoj0000 @varsha123