Release/3.0.0 #480

nikithauc · 2021-07-08T20:19:03Z

Changes in this release are added in the 3.0.0 Milestone and
the V3 upgrade guide

…/microsoftgraph/msgraph-sdk-javascript into JS-Migrate-To-ESLint-Part-1_#308

…icrosoftgraph/msgraph-sdk-javascript into nikitha/graph-clientside-error

* Fixing links * Update v3-upgrade-guide.md

* Adding the ChunkRecord interface * Adding more tests for stream resume * comments, assert conditions change * SliceRecord and comments

* 3.0.0 preview 2 package update * restore file

fix docs markdown link

* adding links to samples * removing duplicate links * adding description for typings and removing en-us

* removing node and browser; adding largefile samples * adding links of samples in docs * token credential readme change

.github/workflows/ci_validation.yml

changelogs/v3-upgrade-guide.md

design/publishing.md

docs/CreatingClientInstance.md

docs/ImplicitMSALAuthenticationProvider.md

baywet · 2021-07-09T15:04:46Z

src/tasks/FileUploadTask/FileObjectClasses/StreamUpload.ts

+	 * @returns The sliced file part
+	 */
+	public async sliceFile(range: Range): Promise<SliceType> {
+		let rangeSize = range.maxValue - range.minValue + 1;


defensive programing on range

src/tasks/FileUploadTask/FileObjectClasses/StreamUpload.ts

src/tasks/FileUploadTask/Interfaces/IUploadEventHandlers.ts

src/tasks/FileUploadTask/Range.ts

src/tasks/FileUploadTask/UploadResult.ts

MIchaelMainer

Vincent caught some valid issues. Since none of these are release blockers, let's open tracking issues to be addressed in 3.0.1 release which can be done next week. Please open tracking issues and provide links in your response to Vincent.

baywet · 2021-07-12T12:52:15Z

@MIchaelMainer my main concern here is this

This library is no longer receiving new features and will only receive critical bug and security fixes. All new applications should use @azure/msal-browser instead.

from https://www.npmjs.com/package/msal

And I think we should seriously review upgrading to the newer package instead of releasing something with a dependency on a deprecated package.

nikithauc · 2021-07-12T15:23:16Z

@baywet msal-browser authprovider is a feature for 3.1.0.
3.1 Milestone
Feature request will deal with msal auth libraries and more work on our auth story.

ImplicitMsalAuthenticationProvider for msal 1.0.0 is deprecated so that we give some time for the users to move to the newer auth library. The deprecation of the ImplicitMsalAuthenticationProvider has been mentioned in the code and upcoming blogpost.
As the name suggests, the ImplicitMsalAuthenticationProvider is for the Implicit Auth flow and cannot directly take a dependency on Msal 2.0.0.

ImplicitMsalAuthenticationProvider is an existing feature that is being deprecated. We are not adding taking a new dependency to msal in this release.

baywet · 2021-07-12T16:36:23Z

@nikithauc thanks for the additional information. Is the plan to remove the implicit provider when adding support for msal browser (and removing msal from the deps) ?

nikithauc · 2021-07-12T16:41:26Z

@nikithauc thanks for the additional information. Is the plan to remove the implicit provider when adding support for msal browser (and removing msal from the deps) ?

@baywet I will have to check on that and get back. The discussion on when to remove is yet to happen.

baywet · 2021-07-12T16:44:37Z

@nikithauc to expand a little bit: removing something, even if it was marked as deprecated before, should be considered a breaking change. In this case, if we decide to keep the implicit flow provider for v3, it means we can only remove it with v4 if we want to avoid breaking people according to semver. This is why I was surprised to see it was still here given the fact the flow has been deprecated for a while now, it forces us to keep a dependency on a deprecated package, and it'll force a new major version.
I do think we should consider removing it now to alleviate all those concerns.

nikithauc · 2021-07-12T17:07:46Z

@nikithauc to expand a little bit: removing something, even if it was marked as deprecated before, should be considered a breaking change. In this case, if we decide to keep the implicit flow provider for v3, it means we can only remove it with v4 if we want to avoid breaking people according to semver. This is why I was surprised to see it was still here given the fact the flow has been deprecated for a while now, it forces us to keep a dependency on a deprecated package, and it'll force a new major version.
I do think we should consider removing it now to alleviate all those concerns.

@baywet I would like to deprecate this now as discussed and remove it in v4.0.
We will be having the custom msal auth providers in 3.1.0. This helps in providing the users more alternatives to migrate to newer auth libraries easily when we remove the ImplicitMsalAuthenticationProvider and they decide to move from Implicit Auth Flow.

cc: @ddyett

nikithauc · 2021-07-12T19:07:06Z

@baywet I have updated the node requirement as I felt that would be relevant for this release. Thanks for pointing that out!

The other enhancement changes will be addressed in other PRs.

nokafor and others added 30 commits December 29, 2019 13:37

Create msgraph-sdk-javascript.yml

aeb9af6

Update msgraph-sdk-javascript.yml

e054775

Installed eslint, removed tslint and related files and added rules

08cf572

Temporary disabling no-mixed-spaces-and-tabs rule

f0bfec0

Adding prettier rule in eslint.rc

eed4f73

Merge branch 'dev' into JS-Migrate-To-ESLint-Part-1_#308

ec45c1b

Merge branch 'dev' into JS-Migrate-To-ESLint-Part-1_#308

e571309

Merge branch 'JS-Migrate-To-ESLint-Part-1_#308' of https://github.com…

459ffeb

…/microsoftgraph/msgraph-sdk-javascript into JS-Migrate-To-ESLint-Part-1_#308

Removing the inline tslint rules

16a3ff0

Added period

7a01c60

Merge branch 'dev' into gallery-automation-updates

ed10042

More rules

7a631d1

Adding token credential auth provider

999b114

testing with samplenpm

9e4db10

Change GraphRequest.count default value to true

6a12f68

custom error non error type set to Graph Error body

289f566

Adding istanbul for code coverage

213bc07

Unit testing empty access token

d06308e

Adding a comment

cd9107c

Adding GraphClientError Class

ee778f9

Adding GraphClientError Class

4c894a8

Adding client secret cred flow

0dab297

Adding unit tests for graph client error class

faccdf6

Merge branch 'dev' into nikitha/graph-clientside-error

cadd22e

Correcting file name and changing the rawresponse condition check

d4d1db0

Merge branch 'nikitha/graph-clientside-error' of https://github.com/m…

09aa804

…icrosoftgraph/msgraph-sdk-javascript into nikitha/graph-clientside-error

Adding unit tests

6e74cda

package json change

a56a103

Adding readme docs

7f12ab6

Merge branch 'dev' into nikitha/graph-clientside-error

d0a5704

nikithauc and others added 11 commits June 2, 2021 13:44

Fixing broken links in documentation (#462)

c7ac5a9

* Fixing links * Update v3-upgrade-guide.md

Resume stream upload (#460)

710de2d

* Adding the ChunkRecord interface * Adding more tests for stream resume * comments, assert conditions change * SliceRecord and comments

Release/3.0.0 preview.2 (#467)

55f15d6

* 3.0.0 preview 2 package update * restore file

Adding customHosts change (#468)

b8b8511

fix docs markdown link

52d1ea1

Merge pull request #472 from Southclaws/patch-1

176d74a

fix docs markdown link

Documentation - add links to JS samples (#473)

c2fe947

* adding links to samples * removing duplicate links * adding description for typings and removing en-us

Remove the azure/identity tip for browser (#478)

dde2550

Updating the samples folder (#477)

af6db7c

* removing node and browser; adding largefile samples * adding links of samples in docs * token credential readme change

Merge branch 'master' into release/3.0.0

68f8ac8

setting version to 3.0.0

0ea2f7b

nikithauc requested review from baywet, MIchaelMainer and ddyett July 8, 2021 20:19

Trigger Build

f4a7c59

baywet requested changes Jul 9, 2021

View reviewed changes

MIchaelMainer previously approved these changes Jul 9, 2021

View reviewed changes

nikithauc mentioned this pull request Jul 10, 2021

Constructor assignment #481

Closed

Setting min node version to 12

4bc0857

nikithauc dismissed MIchaelMainer’s stale review via 4bc0857 July 12, 2021 17:16

nikithauc closed this Aug 2, 2021

nikithauc deleted the release/3.0.0 branch August 2, 2021 18:11

nikithauc mentioned this pull request Aug 2, 2021

Release/3.0.0 #492

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/3.0.0 #480

Release/3.0.0 #480

nikithauc commented Jul 8, 2021

baywet Jul 9, 2021

MIchaelMainer left a comment

baywet commented Jul 12, 2021

nikithauc commented Jul 12, 2021 •

edited

Loading

baywet commented Jul 12, 2021

nikithauc commented Jul 12, 2021

baywet commented Jul 12, 2021

nikithauc commented Jul 12, 2021

nikithauc commented Jul 12, 2021

Release/3.0.0 #480

Release/3.0.0 #480

Conversation

nikithauc commented Jul 8, 2021

baywet Jul 9, 2021

Choose a reason for hiding this comment

MIchaelMainer left a comment

Choose a reason for hiding this comment

baywet commented Jul 12, 2021

nikithauc commented Jul 12, 2021 • edited Loading

baywet commented Jul 12, 2021

nikithauc commented Jul 12, 2021

baywet commented Jul 12, 2021

nikithauc commented Jul 12, 2021

nikithauc commented Jul 12, 2021

nikithauc commented Jul 12, 2021 •

edited

Loading