Validate that PV selection is valid #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of validating that Migration Plans don't share the same namespace, validate that the PVs selected are not shared between Migration Plans. This validation happens on the backend and these modification are to allow the UI to display the proper progress and error messages in the PV selection table. Signed-off-by: Alexander Wels <[email protected]>
|
/cc @dymurray If you could review? |
ibolton336
approved these changes
Oct 8, 2024
rayfordj
pushed a commit
that referenced
this pull request
Oct 16, 2024
Instead of validating that Migration Plans don't share the same namespace, validate that the PVs selected are not shared between Migration Plans. This validation happens on the backend and these modification are to allow the UI to display the proper progress and error messages in the PV selection table. Signed-off-by: Alexander Wels <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of validating that Migration Plans don't
share the same namespace, validate that the PVs
selected are not shared between Migration Plans.
This validation happens on the backend and these
modification are to allow the UI to display the
proper progress and error messages in the PV
selection table.
Matches migtools/mig-controller#1393 which modifies the validation to selected PVs in namespaces instead of namespaces