Fix network requests hanging after app is backgrounded and reopened - #3733
Open
mzaki9 wants to merge 1 commit into
Open
Fix network requests hanging after app is backgrounded and reopened#3733mzaki9 wants to merge 1 commit into
mzaki9 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After backgrounding the app and reopening it, network requests sometimes hang forever (manga pages keep spinning) until the app is force-stopped. This is the known OkHttp stale-connection issue: idle keep-alive connections in the connection pool die while the app is backgrounded (WiFi power-save, radio recycling, network switches) and requests routed to them hang silently until the 5-minute idle reap. With DNS-over-HTTPS enabled, the DoH resolver client builds its own client via
build(), so it has a second, separate pool that nothing ever evicts.Changes:
ConnectionPoolbetween the main client and the DoH resolver client (set on the builder before the DoH provider block), so oneevictAll()clears both pools.NetworkCallbackregistered withregisterDefaultNetworkCallback.ProcessLifecycleOwnerON_START).Testing: