Allow reader Retry after image decode failures - #3770
Open
rodrigdoliveira wants to merge 1 commit into
Open
Conversation
rodrigdoliveira
marked this pull request as ready for review
August 15, 2026 13:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
A page can finish downloading and enter
Page.State.Ready, then fail while the reader is decoding or displaying its image.HttpPageLoader.retryPage()currently changes the page back toQueueonly when its state isError. For a display failure on an otherwise ready page, Retry adds the page to the priority queue without changing it back to a loadable state. The loader can then skip the new image request.Change
Retry now unconditionally sets the selected page to
Page.State.Queuebefore placing it in the retry queue.The method is only called from the reader's explicit Retry action, so this keeps the existing forced-reload behavior while also covering failures that happen after the download was marked ready.
Validation
./gradlew spotlessCheck./gradlew :app:testDebugUnitTestNo reader UI or normal page-loading behavior is changed.