Fix: Local source filtering - #3782
Open
mugetau wants to merge 1 commit into
Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local source didn't use any metadata from ComicInfo.xml (or the legacy details.json) when browsing/searching. Only the folder name was searchable, so tags like
genre,author,artist, andpublishing statuswere effectively write-only.This adds:
Metadata is parsed from each manga's top-level
ComicInfo.xml, falling back to the legacydetails.jsonif that's what a given manga folder has (read in parallel across the library, and only when a filter/query is actually active, so plain browsing with no filters is unaffected performance-wise).For visibility: I'm aware of #437, which tackles this alongside broader indexing/performance work. This PR is a narrower, immediately mergeable fix for the search/filter bug specifically (#397), not a replacement for that effort.
Closes #397
Testing / self-review
ComicInfo.xmlfiles covering different genres/authors/status values; confirmed each filter narrows results correctly, and that they combine (e.g. genre + status together).Filter.Text/Filter.Selectcomponents already used by other sources, so they render through the app's existing filter sheet and pick up theming/tablet layout for free. Nothing to check there beyond confirming the sheet still displays correctly, which it does.