Refactor backup creation and restoration to stream manga entries - #3850
Open
NGB-Was-Taken wants to merge 1 commit into
Open
Refactor backup creation and restoration to stream manga entries#3850NGB-Was-Taken wants to merge 1 commit into
NGB-Was-Taken wants to merge 1 commit into
Conversation
Uses less memory and should fix backup/restore failures caused by OOM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses less memory and should fix backup/restore failures caused by OOM
Tested on a 21MiB backup file with 463,309 chapters across 14,298 entries.
Data obtained via
dumpsys meminfo app.mihon(monitoringTOTAL PSS, polled every 2 seconds, visualized with Matplotlib)Backup structure remains unchanged. Verified by cross-restoring between stable and this implementation.
Both backup creation and restoration take slightly longer, which is an acceptable trade-off for less memory usage.