Fix GPU memory leak in WebGpuViewer when jumping pages - #3872
Open
Danidukiyu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3863
Summary
When using the page navigator slider to rapidly jump through a chapter on the new WebGpu renderer, pages that were queued and subsequently evicted from the
WebGpuViewercache before they finished decoding were leaking their GPU textures.This PR adds a missing
imagePage.cleanup()call indecodeReaderPageto ensure that if a page finishes decoding but has already been evicted from the cache, the newly allocated texture is properly destroyed.